Skip to content

Commit e5e44c2

Browse files
florianbuergerJosh Holtz
authored and
Josh Holtz
committed
Fallback to CFBundleName if CFBundleDisplayName is nil (fastlane-community#64)
`CFBundleDisplayName` is not set in the default iOS project template. See fastlane-community#62
1 parent e13dd03 commit e5e44c2

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

lib/fastlane/plugin/aws_s3/actions/aws_s3_action.rb

+5-1
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,11 @@ def self.upload_ipa(s3_client, params, s3_region, s3_access_key, s3_secret_acces
168168
build_num = info['CFBundleVersion']
169169
bundle_id = info['CFBundleIdentifier']
170170
bundle_version = info['CFBundleShortVersionString']
171-
title = CGI.escapeHTML(info['CFBundleDisplayName'])
171+
display_name = info['CFBundleDisplayName']
172+
if display_name.nil?
173+
display_name = info['CFBundleName']
174+
end
175+
title = CGI.escapeHTML(display_name)
172176
full_version = "#{bundle_version}.#{build_num}"
173177

174178
# Creating plist and html names

0 commit comments

Comments
 (0)