Create less promises in GraphQL.operate() when the reloadOnLoad and reloadOnLoad options are false.

Author: jaydenseric

changelog.md

@@ -18,6 +18,7 @@
 - Improved the test utility `promisifyEvent` function.
 - Test the `GraphQL.operate()` option `reloadOnLoad` in isolation.
 - Test better the order of `GraphQL.operate()` triggered events.
+- Reduced the number of promises created by `GraphQL.operate()` when the `reloadOnLoad` and `reloadOnLoad` options are `false`.
 - Added a code example for how to await all loading GraphQL operations.
 - Used consistent JSDoc types for promises that resolve `void`.
 

src/universal/GraphQL.js

@@ -305,12 +305,15 @@ module.exports = class GraphQL {
     const cacheKey = cacheKeyCreator(fetchOptions);
     const cacheValuePromise = this.fetch(fetchOptions, cacheKey);
 
-    // Potential edge-case issue: Multiple identical queries with `resetOnLoad`
-    // enabled will cause excessive resets.
-    cacheValuePromise.then(() => {
-      if (reloadOnLoad) this.reload(cacheKey);
-      else if (resetOnLoad) this.reset(cacheKey);
-    });
+    // A reload or reset happens after the cache is updated as a side effect.
+    if (reloadOnLoad)
+      cacheValuePromise.then(() => {
+        this.reload(cacheKey);
+      });
+    else if (resetOnLoad)
+      cacheValuePromise.then(() => {
+        this.reset(cacheKey);
+      });
 
     return {
       cacheKey,