Use tuple for m2m_models#1438
Open
martimarkov wants to merge 1 commit intodjango-commons:masterfrom
Open
Conversation
Member
|
Until the tests run for this, we can't move forward with it. This likely means it's blocked by jazzband/help#382 That said, this will need tests confirming the fix from #1435, documentation changes and maybe some way to avoid being backwards incompatible. |
Author
|
@tim-schilling so you want me to add tests that cause #1435 as an issue and this to fix them? I'm not sure I'll be able to reproduce it correctly but will think about how to do it |
Member
|
Yes, that's correct. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes how the
m2m_modelsis defined.Description
Uses a tuple containing the object name and the field.
Related Issue
#1435
Motivation and Context
Ensures that there are no clashes when the m2m relationship is in a parent model and there are multiple child models.
How Has This Been Tested?
Ran all the tests in the suite and no issues came up.
Screenshots (if appropriate):
Types of changes
Checklist:
pre-commit runcommand to format and lint.AUTHORS.rstCHANGES.rst