From 45cfc13a076cd7202351b7b742e5308d54c0ee53 Mon Sep 17 00:00:00 2001
From: Dan Swain <dan@danswain.com>
Date: Wed, 17 Jan 2024 15:36:20 -0500
Subject: [PATCH] Prevent empty <ul> from being rendered in profile.html

Empty <ul> was being rendered when backup_phones == None
---
 .../templates/two_factor/profile/profile.html | 24 ++++++++++---------
 1 file changed, 13 insertions(+), 11 deletions(-)

diff --git a/two_factor/templates/two_factor/profile/profile.html b/two_factor/templates/two_factor/profile/profile.html
index 0c86ba386..b3731356a 100644
--- a/two_factor/templates/two_factor/profile/profile.html
+++ b/two_factor/templates/two_factor/profile/profile.html
@@ -12,19 +12,21 @@ <h1>{% block title %}{% trans "Account Security" %}{% endblock %}</h1>
       <h2>{% trans "Backup Phone Numbers" %}</h2>
       <p>{% blocktrans trimmed %}If your primary method is not available, we are able to
         send backup tokens to the phone numbers listed below.{% endblocktrans %}</p>
-      <ul>
-        {% for phone in backup_phones %}
-          <li>
-            {{ phone|as_action }}
-            <form method="post" action="{% url 'two_factor:phone_delete' phone.id %}"
+      {% if backup_phones %}
+        <ul>
+          {% for phone in backup_phones %}
+            <li>
+              {{ phone|as_action }}
+              <form method="post" action="{% url 'two_factor:phone_delete' phone.id %}"
                   onsubmit="return confirm({% trans 'Are you sure?' %})">
-              {% csrf_token %}
-              <button class="btn btn-sm btn-warning"
+                {% csrf_token %}
+                <button class="btn btn-sm btn-warning"
                       type="submit">{% trans "Unregister" %}</button>
-            </form>
-          </li>
-        {% endfor %}
-      </ul>
+              </form>
+            </li>
+          {% endfor %}
+        </ul>
+      {% endif %}
       <p><a href="{% url 'two_factor:phone_create' %}"
         class="btn btn-info">{% trans "Add Phone Number" %}</a></p>
     {% endif %}