Bootstrap4 Templates

[PaulBrownMagic]

Bootstrap4 is now up to version 4.3 and is stable. As Bootstrap3 templates are included, perhaps providing Bootstrap4 ones could also be done?

[ababic]

Hi @PaulBrownMagic. Sure, I'd be happy to have a set of templates for bootstrap 4. If you have experience with it, I'd gratefully accept a pull request?

[PaulBrownMagic]

Sure, I'd be happy to, I think I can drag the code from an existing project. Give me a week or so to fit it into my schedule.

[ababic]

Thanks @PaulBrownMagic, that'd be great. Please take a look at our contributing guidelines There are some good tips in there for developing locally, which could save you a bit of pain in getting set up :)

[kbayliss]

Hey @PaulBrownMagic, did you manage to get anywhere with this? If not i'll pick this up as I'm keen to use them too :).

[PaulBrownMagic]

Sure, I've pulled my templates out of a project and pushed them to my fork: https://github.com/PaulBrownMagic/wagtailmenus

If you'd double check them for me I'll create the pull request?

[linuxluigi]

Thanks for the work, I just test it and it works quite good :)

Only in main_menu_dropdown.html I needed to change
<a href="{{ item.href }}" class="nav-item{% if item.has_children_in_menu %} dropdown-toggle" ...
to
<a href="{{ item.href }}" class="nav-link{% if item.has_children_in_menu %} dropdown-toggle" ...

[PaulBrownMagic]

Fixed it.