From 7fd572434ac38e7b7cd2f1673251c2f60b6a5176 Mon Sep 17 00:00:00 2001 From: jbe2277 Date: Fri, 19 Jul 2024 21:35:51 +0200 Subject: [PATCH] Writer: Reference ValueConverters via Static instead of StaticResource --- .../Writer/Writer.Presentation/App.xaml | 1 - .../Converters/DoubleToZoomConverter.cs | 2 ++ .../Converters/MenuFileNameConverter.cs | 2 ++ .../Converters/PercentConverter.cs | 2 ++ .../Converters/TabFileNameConverter.cs | 2 ++ .../Converters/TitleConverter.cs | 2 ++ .../Resources/ConverterResources.xaml | 22 --------------- .../Writer.Presentation/Views/MainView.xaml | 6 ++-- .../Views/PrintPreviewView.xaml | 3 +- .../Views/ShellWindow.xaml | 28 ++++++++++--------- .../Writer.Presentation/Views/StartView.xaml | 8 ++++-- 11 files changed, 36 insertions(+), 42 deletions(-) delete mode 100644 src/System.Waf/Samples/Writer/Writer.Presentation/Resources/ConverterResources.xaml diff --git a/src/System.Waf/Samples/Writer/Writer.Presentation/App.xaml b/src/System.Waf/Samples/Writer/Writer.Presentation/App.xaml index 88cc95d6..02818cf4 100644 --- a/src/System.Waf/Samples/Writer/Writer.Presentation/App.xaml +++ b/src/System.Waf/Samples/Writer/Writer.Presentation/App.xaml @@ -6,7 +6,6 @@ - diff --git a/src/System.Waf/Samples/Writer/Writer.Presentation/Converters/DoubleToZoomConverter.cs b/src/System.Waf/Samples/Writer/Writer.Presentation/Converters/DoubleToZoomConverter.cs index ea7cc8b3..133a8493 100644 --- a/src/System.Waf/Samples/Writer/Writer.Presentation/Converters/DoubleToZoomConverter.cs +++ b/src/System.Waf/Samples/Writer/Writer.Presentation/Converters/DoubleToZoomConverter.cs @@ -5,6 +5,8 @@ namespace Waf.Writer.Presentation.Converters; public class DoubleToZoomConverter : IValueConverter { + public static DoubleToZoomConverter Default { get; } = new(); + public object? Convert(object? value, Type? targetType, object? parameter, CultureInfo? culture) => (double)value! * 100; public object? ConvertBack(object? value, Type? targetType, object? parameter, CultureInfo? culture) => (double)value! / 100; diff --git a/src/System.Waf/Samples/Writer/Writer.Presentation/Converters/MenuFileNameConverter.cs b/src/System.Waf/Samples/Writer/Writer.Presentation/Converters/MenuFileNameConverter.cs index e57a03bc..42f447be 100644 --- a/src/System.Waf/Samples/Writer/Writer.Presentation/Converters/MenuFileNameConverter.cs +++ b/src/System.Waf/Samples/Writer/Writer.Presentation/Converters/MenuFileNameConverter.cs @@ -8,6 +8,8 @@ public class MenuFileNameConverter : IValueConverter { private const int MaxCharacters = 40; + public static MenuFileNameConverter Default { get; } = new(); + public object? Convert(object? value, Type? targetType, object? parameter, CultureInfo? culture) { if (value is not string fileName || string.IsNullOrEmpty(fileName)) return ""; diff --git a/src/System.Waf/Samples/Writer/Writer.Presentation/Converters/PercentConverter.cs b/src/System.Waf/Samples/Writer/Writer.Presentation/Converters/PercentConverter.cs index d5939ce2..8252b25f 100644 --- a/src/System.Waf/Samples/Writer/Writer.Presentation/Converters/PercentConverter.cs +++ b/src/System.Waf/Samples/Writer/Writer.Presentation/Converters/PercentConverter.cs @@ -6,6 +6,8 @@ namespace Waf.Writer.Presentation.Converters; public class PercentConverter : IValueConverter { + public static PercentConverter Default { get; } = new(); + public object? Convert(object? value, Type? targetType, object? parameter, CultureInfo? culture) => string.Format(culture, "{0:P0}", value); public object? ConvertBack(object? value, Type? targetType, object? parameter, CultureInfo? culture) diff --git a/src/System.Waf/Samples/Writer/Writer.Presentation/Converters/TabFileNameConverter.cs b/src/System.Waf/Samples/Writer/Writer.Presentation/Converters/TabFileNameConverter.cs index 4c7ea9c4..d508c781 100644 --- a/src/System.Waf/Samples/Writer/Writer.Presentation/Converters/TabFileNameConverter.cs +++ b/src/System.Waf/Samples/Writer/Writer.Presentation/Converters/TabFileNameConverter.cs @@ -9,6 +9,8 @@ public class TabFileNameConverter : IMultiValueConverter { private const int MaxCharacters = 40; + public static TabFileNameConverter Default { get; } = new(); + public object? Convert(object?[]? values, Type? targetType, object? parameter, CultureInfo? culture) { if (values == null || values.Length != 2 || values[0] is not string || values[1] is not bool) diff --git a/src/System.Waf/Samples/Writer/Writer.Presentation/Converters/TitleConverter.cs b/src/System.Waf/Samples/Writer/Writer.Presentation/Converters/TitleConverter.cs index 6433dc7d..26ecb0d1 100644 --- a/src/System.Waf/Samples/Writer/Writer.Presentation/Converters/TitleConverter.cs +++ b/src/System.Waf/Samples/Writer/Writer.Presentation/Converters/TitleConverter.cs @@ -7,6 +7,8 @@ namespace Waf.Writer.Presentation.Converters; public class TitleConverter : IMultiValueConverter { + public static TitleConverter Default { get; } = new(); + public object? Convert(object?[]? values, Type? targetType, object? parameter, CultureInfo? culture) { if (values == null || values.Length != 2 || values[0] is not string || !(values[1] == null || values[1] is string)) return DependencyProperty.UnsetValue; diff --git a/src/System.Waf/Samples/Writer/Writer.Presentation/Resources/ConverterResources.xaml b/src/System.Waf/Samples/Writer/Writer.Presentation/Resources/ConverterResources.xaml deleted file mode 100644 index 026bceb2..00000000 --- a/src/System.Waf/Samples/Writer/Writer.Presentation/Resources/ConverterResources.xaml +++ /dev/null @@ -1,22 +0,0 @@ - - - - - - - - - - - - - - - - - - - \ No newline at end of file diff --git a/src/System.Waf/Samples/Writer/Writer.Presentation/Views/MainView.xaml b/src/System.Waf/Samples/Writer/Writer.Presentation/Views/MainView.xaml index 6ae22e8f..30b9913b 100644 --- a/src/System.Waf/Samples/Writer/Writer.Presentation/Views/MainView.xaml +++ b/src/System.Waf/Samples/Writer/Writer.Presentation/Views/MainView.xaml @@ -1,6 +1,8 @@  - +