Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parentheses error importing tree with R version 4.1.1 #39

Open
jrede opened this issue Nov 19, 2021 · 4 comments
Open

Parentheses error importing tree with R version 4.1.1 #39

jrede opened this issue Nov 19, 2021 · 4 comments

Comments

@jrede
Copy link

jrede commented Nov 19, 2021

Hi @jbisanz ,

I recently updated R to 4.1.1 because of compatibility issues. However, now when I try to import a .qza tree file I get the following error:

Error in FUN(X[[i]], ...) :
numbers of left and right parentheses in Newick string not equal

Any idea how to fix this without running two versions of R?

Thanks!
Jordan

@roxanacoras
Copy link

Hi, I have the exact same problem!
I would appreciate your help with fixing this.

Thanks a lot,
Roxana

@mestaki
Copy link

mestaki commented Dec 20, 2021

I believe this is the same as #33 resulting from something with newest version of "ape".
If ape is just being used for reading the tree then phytools::read.newick("tree.nwk") could be an easy replacement? Worked fine for me from an extract Q2 tree.

@jbisanz
Copy link
Owner

jbisanz commented Jan 26, 2022

@mestaki That sounds like a great idea. Could you test this and do a pull request? You would add phytools to DESCRIPTION, add in the import of read.newick to NAMESPACE and change line 48 of R/read_qza.R,

@mestaki
Copy link

mestaki commented Jan 28, 2022

Sounds good @jbisanz, hopefully I'll have some time next week to test this properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants