Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: update esbuild dep #191

Open
falsifian opened this issue Feb 11, 2023 · 1 comment
Open

Request: update esbuild dep #191

falsifian opened this issue Feb 11, 2023 · 1 comment

Comments

@falsifian
Copy link

falsifian commented Feb 11, 2023

Running npm install from the frontend directory on OpenBSD gives:

h4 frontend $ npm install
npm ERR! code 1
npm ERR! path /home/falsifian/co/beancount-import/frontend/node_modules/esbuild
npm ERR! command failed
npm ERR! command sh -c -- node install.js
npm ERR! Unsupported platform: openbsd x64 LE

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/falsifian/.npm/_logs/2023-02-11T01_13_52_718Z-debug-0.log

This was fixed in esbuild v0.11.18: evanw/esbuild@eb2872e

The following change (against 850c2c3) fixes it for me, though I haven't looked at the esbuild or done any testing beyond going through my import routine once, so I don't know if this will subtly break anything:

--- frontend/package.json
+++ frontend/package.json
@@ -23,7 +23,7 @@
   "dependencies": {
     "codemirror": "^5.59.4",
     "common-prefix": "^1.1.0",
-    "esbuild": "^0.9.0",
+    "esbuild": "^0.17.0",
     "fbemitter": "^3.0.0",
     "fuzzyjs": "^4.0.4",
     "lodash": "^4.17.21",
@falsifian
Copy link
Author

Ping. beancount-import won't build on OpenBSD without updating this dependency. Today I built it with "^0.20.2" instead of "^0.17.0" seen above and it is still working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant