Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUYOTHER and SELLOTHER OFX transaction types are not recognized #196

Open
asciipip opened this issue Mar 15, 2023 · 1 comment
Open

BUYOTHER and SELLOTHER OFX transaction types are not recognized #196

asciipip opened this issue Mar 15, 2023 · 1 comment

Comments

@asciipip
Copy link

One of my institutions uses BUYOTHER and SELLOTHER types for most of the transactions in its OFX files. See example.zip for a small example.

beancount_import doesn't recognize those and just ignores them. It should treat them like other stock transaction types.

If I have time, I'll see about putting together a pull request, but I was able to get it to work by editing ofx.py in roughly the following ways:

  • Adding , 'BUYOTHER', 'SELLOTHER' to STOCK_BUY_SELL_TYPES just before the definition of ParsedOfxStatement
  • Adding , 'SELLOTHER' to SELL_TYPES on the next line
  • Adding |buyother|sellother to the transaction type regex near the beginning of ParsedOfxStatement.__init__()
@Zburatorul
Copy link
Collaborator

Would be great to get a PR from you on this. We can refine from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants