Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not properly clear transactions with multiple postings on the main account #232

Open
sclu1034 opened this issue Jan 30, 2024 · 2 comments · May be fixed by #234
Open

Does not properly clear transactions with multiple postings on the main account #232

sclu1034 opened this issue Jan 30, 2024 · 2 comments · May be fixed by #234

Comments

@sclu1034
Copy link

sclu1034 commented Jan 30, 2024

With a generic_importer_source, if a transaction has multiple postings with the importer's main account (e.g. to split regular salary and bonus in a payslip), upon import only the first such posting will get the source_desc meta field to be cleared.
The logic to check for uncleared postings, however, then checks all such postings, and marks it as uncleared, because some postings weren't cleared during import.

I then have to go in and manually copy over the meta field (or set cleared: TRUE) to the other posting(s).

@dumbPy
Copy link
Contributor

dumbPy commented Feb 15, 2024

@sclu1034
It clearly is an oversight from my side when I implemented the generic importer source. I didn't knew better.

Try removing this break and the one below it

Now it would add source description to each posting of the source account.
Or else you can keep a flag, add source desc to first posting and cleared: TRUE to rest here.

Let me know if it works.
You are welcome to raise a PR if it works

@sclu1034
Copy link
Author

In the meantime, I ended up tweaking my pipeline to have it add cleared meta tags.

I did test removing those breaks by editing in-place, and that seems to work. But I don't really have an environment set up to properly contribute.

dumbPy added a commit to dumbPy/beancount-import that referenced this issue Apr 21, 2024
@dumbPy dumbPy linked a pull request Apr 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants