Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility of updating "pullspecs" #181

Closed
kyguy opened this issue Apr 30, 2020 · 3 comments
Closed

Possibility of updating "pullspecs" #181

kyguy opened this issue Apr 30, 2020 · 3 comments

Comments

@kyguy
Copy link
Collaborator

kyguy commented Apr 30, 2020

OSBS team is requesting we update env vars in our manifest files that specify multiple images/values to just specify one. This is to fall inline with their automation efforts with SHA digests. For example:

 - name: STRIMZI_KAFKA_IMAGES
   value: |
     2.0.0=registry.access.redhat.com/amq7/amq-streams-kafka:1.1.0-kafka-2.0.0
     2.1.1=registry.access.redhat.com/amq7/amq-streams-kafka:1.1.0-kafka-2.1.1

I know this format is used to support upgrades for AMQ Streams, so this issue is to discuss the feasibility/possibility of this being changed or if we should push back on the requirement. If it is possible, what should the format look like?

@kyguy kyguy changed the title Possblity of updating "pullspecs" Possiblity of updating "pullspecs" Apr 30, 2020
@kyguy kyguy changed the title Possiblity of updating "pullspecs" Possibility of updating "pullspecs" Apr 30, 2020
@kyguy
Copy link
Collaborator Author

kyguy commented May 18, 2020

As discussed offline, these changes would not be worth the incurred overhead. Looking into alternatives, for instance, using annotations to hold pull.specs for OSBS [1]. OSBS would retrieve the pull.specs from the annotations and replace all of the equivalent pull.specs listed in the CSV file with the SHA digests. The only issue is that the type of SHAs digests that are swapped in are manifest digest lists which are not supported by the OpenShift internal registry and will break our S2I feature. We need platform specific digests

[1] https://osbs.readthedocs.io/en/latest/users.html#pullspec-locations

@k-wall
Copy link
Collaborator

k-wall commented Sep 16, 2024

@kyguy is this issue still relevant?

@kyguy kyguy closed this as completed Oct 16, 2024
@kyguy
Copy link
Collaborator Author

kyguy commented Oct 16, 2024

Closing as this is no longer relevant, all issues have been fixed by internal services

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants