Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Will not allow '>' at the end of any cfml tags #34

Closed
Yamaha32088 opened this issue Jul 29, 2016 · 13 comments
Closed

Will not allow '>' at the end of any cfml tags #34

Yamaha32088 opened this issue Jul 29, 2016 · 13 comments

Comments

@Yamaha32088
Copy link

Yamaha32088 commented Jul 29, 2016 •
edited
Loading

Another developer and I noticed that when we try to type something like <cfset foo="bar"> the closing > will not be printed. It is like the key is disabled. We were on the most recent branch as well using the latest version of Sublime.
@Yamaha32088 Yamaha32088 changed the title Will not allow me to add '>' at the end of any cfml tags Will not allow '>' at the end of any cfml tags Jul 29, 2016
@jcberquist
Copy link
Owner

Can you verify that you are using this package and not https://github.com/SublimeText/ColdFusion?

I know this issue has occured with SublimeText/ColdFusion (e.g. SublimeText/ColdFusion#106)

If you are using this package, and you have SublimeText/ColdFusion installed as well, can you please add ColdFusion to your ignored_packages user setting, restart Sublime Text, and see if the problem persists?

I can't reproduce it with just this plugin. If it still happens after disabling SublimeText/ColdFusion, could you please provide a minimal file string in a fenced code block where the error occurs for you? For example:

<html>
<cfset foo="bar"
</html>

@Yamaha32088
Copy link
Author

We did have that package installed. I get the same thing after disabling all packages and removing them from the Packages directory. I have tried both CFC and CFML but get the same results with a brand new file and where the only line is <cfset foo="bar"> the tag does not print. I tried some of the troubleshooting steps in the issue that you referenced and when I turn on debugging it says

cfml_auto_insert_closing_tag

So it seems to be trying to run the function correctly but just not outputting anything.

@jcberquist
Copy link
Owner

I assume after running sublime.log_commands(True) and pressing >, when you see cfml_auto_insert_closing_tag printed to the console, that it is the only thing printed to the console? I am not really sure what is going on at this point, so here are some general questions.

  • What OS and what version of ST do you have?
  • Did you install this package with Package Control, or via download/git clone?
  • If you go to preferences -> Browse Packages, is it contained in a folder in that directory?
  • Are you sure you entirely removed SublimeText/ColdFusion? You say you "tried both CFC and CFML" but CFC should not be an option for you in your syntaxes if the SublimeText/ColdFusion package has been removed.
  • Have you looked in your User folder (under Packages) for any key-binding files? If you have any, could you check for any key-bindings to the > key?
  • Is it possible for you to try this on a clean install of ST3 (possibly a portable version) with just Package Control and CFML to see if this issue happens then?

@Shult2
Copy link

Shult2 commented Aug 9, 2016 •
edited
Loading

I am having the same issue.
Windows 10, Sublime Text 3114.
Downloaded via git download.
In packages I have "sublimetext-cfml-master" folder.
The other sublime cold fusion packages I have are removed.
I use snippets, not keybinding.

I have Emmett installed, will this cause a collision?

Screenshot of me trying to add a ">":
cfcommand
closingtag

@Shult2
Copy link

Shult2 commented Aug 9, 2016

And I also cannot add a "/" to close a tag set. It says "command: close_cfml_tag" in the console.
forwardslash

@jcberquist
Copy link
Owner

If you close and then open Sublime Text, then open the console, do you see any import errors? I think I may have hard coded a path in the package which could be the source of this problem.

@Shult2
Copy link

Shult2 commented Aug 9, 2016

Yes, it says, "ImportError: No module named 'CFML'"

jcberquist added a commit that referenced this issue Aug 10, 2016
@jcberquist
Removed hard coded import paths
42cfa33 
These were causing import errors when package was installed in a folder
with a name other than `CFML` . Hopefully fixes the problems in #34
@jcberquist
Copy link
Owner

@Shult2: Thanks, I have removed the hard coded import paths, it should hopefully fix the issue you are seeing.
@Yamaha32088: If you installed the package manually in a folder with a name other than CFML it is likely that your issue had the same cause. If so, please download the latest master and try it out.

@Shult2
Copy link

Shult2 commented Aug 10, 2016

Appears to be working. You rock!

@jcberquist
Copy link
Owner

@Shult2: Thanks for confirming.

@Yamaha32088: I am going to close this, as 42cfa33 does fix an issue that was causing behavior similar to what you described. If after trying the latest master this is still an issue for you please let me know.

@jcberquist jcberquist mentioned this issue Aug 20, 2016
Closed
@vm-jade
Copy link

vm-jade commented Oct 4, 2016

Hi, I still seem to be having the problem described here (unable to type ">" or "/"). The console outputs the same commands as Shult2, except no "ImportError" appears upon load (I'm using Mac OS).

CFML package: v0.16.0
Sublime: Stable channel, build 3126
OS X El Capitan 10.11.3

The comment in 42cfa33 hints at having a folder named "CFML"—is it possible this still doesn't work for OS X which only has an "Installed Packages" folder?

@jcberquist
Copy link
Owner

Hi, as a starting point for debugging this, could you take a look at the questions here: #42 (comment)?

You have already given the plugin version, and you indicate that the commands are logged to the console. So it would be helpful to know to if you installed the plugin via package control, and if you have ever installed it manually or not.

@vm-jade
Copy link

vm-jade commented Oct 5, 2016

Hi, this seems to be working for me now after a second reboot—apologies for the false alarm (I was using package control only). Thanks for the reply. and for the great sublime package :)

@jcberquist jcberquist mentioned this issue Nov 8, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jcberquist @Yamaha32088 @vm-jade @Shult2