Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking layout when data-open is false #8

Open
lucasghizoni opened this issue Feb 17, 2017 · 1 comment
Open

Breaking layout when data-open is false #8

lucasghizoni opened this issue Feb 17, 2017 · 1 comment

Comments

@lucasghizoni
Copy link

Hello, I would like to know why you guys used the following code on date-input-polyfill.scss:

&[data-open="false"] {
visibility: hidden;
z-index: -100 !important;
top: 0;
}

Instead of just using this:

&[data-open="false"] {
display: none;
}

I am questioning that, because the date-input-polyfill Element is occupying some space when attribute data-open is false, breaking my layout. If you agree with this little change, i make a pull request.

@jcgertig
Copy link
Owner

try it in a fork and see how it goes if everyting is working correctly make a pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants