Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate tests from ocaml-lang-server #1

Open
jchavarri opened this issue Mar 31, 2019 · 0 comments
Open

Migrate tests from ocaml-lang-server #1

jchavarri opened this issue Mar 31, 2019 · 0 comments
Labels
good first issue Good for newcomers

Comments

@jchavarri
Copy link
Owner

There were some nice tests in https://github.com/freebroccolo/ocaml-language-server/tree/master/__tests__ that would be awesome to migrate.

One note is that the line numbers produced have changed in this package. Problem matchers expects lines to be in 1..n while the lang server, which worked with vscode Diagnostics API, was producing ranges in 0..n-1.
@jchavarri jchavarri added the good first issue Good for newcomers label Mar 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jchavarri