Skip to content

Commit 687ce1e

Browse files
committed
fix: run job not working for non-scheduled job
1 parent 390b0fb commit 687ce1e

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

entity/builder.go

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@ type BuildConfig struct {
8787
job gocron.Job
8888
jobDefinition gocron.JobDefinition
8989
jobTask gocron.Task
90+
jobFn func()
9091

9192
componentType Domain
9293
objectID string
@@ -365,8 +366,7 @@ func (e *BuildConfig) ScheduleJob(jobDefinition gocron.JobDefinition, handler Se
365366
log.Warn().Str("name", e.Config.Name).Msg("entity can only have one job definition")
366367
}
367368

368-
e.jobDefinition = jobDefinition
369-
e.jobTask = gocron.NewTask(func() {
369+
e.jobFn = func() {
370370
start := time.Now()
371371

372372
err := handler(entity, client, scheduler)
@@ -377,7 +377,9 @@ func (e *BuildConfig) ScheduleJob(jobDefinition gocron.JobDefinition, handler Se
377377
if err != nil {
378378
log.Err(err).Str("name", e.Config.Name).Msg("failed to update")
379379
}
380-
})
380+
}
381+
e.jobTask = gocron.NewTask(e.jobFn)
382+
e.jobDefinition = jobDefinition
381383

382384
return nil
383385
}).
@@ -389,8 +391,9 @@ func (e *BuildConfig) ScheduleJob(jobDefinition gocron.JobDefinition, handler Se
389391
}
390392
e.job = nil
391393
}
392-
e.jobDefinition = nil
394+
e.jobFn = nil
393395
e.jobTask = nil
396+
e.jobDefinition = nil
394397
return nil
395398
})
396399
return e

entity/entity.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ func (e *Entity) RunJob() error {
6363
return e.config.job.RunNow()
6464
}
6565
// otherwise invoke it directly
66-
e.config.jobTask()
66+
e.config.jobFn()
6767
return nil
6868
}
6969

0 commit comments

Comments
 (0)