Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI translate seems missing in Ignored List #14

Closed
BackMountainDevil opened this issue Oct 14, 2023 · 2 comments
Closed

UI translate seems missing in Ignored List #14

BackMountainDevil opened this issue Oct 14, 2023 · 2 comments

Comments

@BackMountainDevil
Copy link
Contributor

As you can see in the image, you could might only know a word 'title'.

截图_2023-10-14_19-54-38

I am sure I do not translate test_notification_title startwith title, I translate it into "这是一条用来测试验证码提取的通知".

So I guess:

  1. it use sms title to ignore
  2. forget to add the title into translate keys, that is not found in string.xml

so I have a question, should we add a new translate key to title?

@jd1378
Copy link
Owner

jd1378 commented Oct 14, 2023

Hi !
I'm sorry, the ignore list screen is somewhat incomplete
there's "tag:", "app:" and "nid:" as well, and they don't make sense to users,
so I should have taken time to properly make a component that reflects the item of the list
"title:" is part of detection mechanism,
to show the list correctly I have to make an extra component and show what it's using to ignore the said notification

so yeah, But I should make the component first, and I'm a bit busy right now, so it may take a while

thanks for bringing this up though

@jd1378
Copy link
Owner

jd1378 commented Jul 11, 2024

this should be resolved in upcoming version (1.16.0)

@jd1378 jd1378 closed this as completed Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants