Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy unit prefixes for bit rate #40

Open
akosladanyi opened this issue Nov 27, 2021 · 1 comment
Open

Legacy unit prefixes for bit rate #40

akosladanyi opened this issue Nov 27, 2021 · 1 comment

Comments

@akosladanyi
Copy link

BitRate:
type: string
pattern: '^\d+(\.\d+)? (bps|Kbps|Mbps|Gbps|Tbps)$'
description: String representing a bit rate that shall be formatted as follows.

The units for bit rate seem to use a legacy notation: bps, Kbps, Mbps, Gbps, Tbps [1].

These should be bps, Kibps, Mibps, Gibps, Tibps (multiplier = 1024) or bps, kbps, Mbps, Gbps, Tbps (multiplier = 1000).

[1] https://en.wikipedia.org/wiki/Binary_prefix

@jdegre
Copy link
Owner

jdegre commented Dec 9, 2021

Thanks for the feedback @akosladanyi

The intention is to have these units as "multiplier = 1000", so the only one that seems to be wrong is "Kbps" that should've been "kbps".

Now, the problem is how to fix this in a backwards-compatible way. I guess the simplest way would be to add a clarification in the description indicating that "Kbps" is used by mistake to actually mean the same thing as "kbps".

Simply adding "kbps" as an allowed unit in the regex pattern would not work, I'm afraid, since a sender using this "new" unit format will not interoperate with an older receiver which only understands "Kbps".

I'll make sure the issue is discussed at next 3GPP meeting, and we'll see how to address this problem. Thanks for reporting it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants