Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We extended some of the loading routine code from this repository #4

Open
wgottwald opened this issue Mar 4, 2023 · 5 comments
Open

Comments

@wgottwald
Copy link

We used some code from the loading functions for acqp and method files from this repository and implemented our own data analysis package for Bruker MRI/MRS data. Its just private now within our research group at the Technical University of Munich, but can we make it publicly available (with a reference to this repository of course)?

@jdoepfert
Copy link
Owner

Hi Wolfgang, thanks for reaching out. Even better would be if you could somehow import brukerMRI into within your code base, but this would need some refactoring first to make brukerMRI installable. Let me know if this would be an option. Otherwise, sure it would be fine for me to include some code if you include a reference :)

@jdoepfert
Copy link
Owner

You could ofc also create a PR including your extensions

@wgottwald
Copy link
Author

Hi Jörg, thanks for the quick answer.

Yes ideally we would just import the functions that we need from brukerMRI (we only need ParseSingleValue, ParseArrayand a modified form of ReadParamFile). However we use them within a class and therefore modified them slightly, which complicates things a bit but I guess we could work that out. Also brukerMRI is designed for Python 2.7, which is outdated and therefore the package would probably need some changes to make it compatible with Python >3.7?

Maybe for now its easier if we use these functions within our package and cite them within the function until an installable working version of brukerMRI is available?

As these functions are your code I think its up to you to decide what your favorite option is, just let me know.

@jdoepfert
Copy link
Owner

Maybe for now its easier if we use these functions within our package and cite them within the function until an installable working version of brukerMRI is available?
OK. I will work on a package+python 3 support in the meantime and let you know as soon as it's available

@wgottwald
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants