-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement - Log Tab Title #71
Comments
Thank you! I think this is working correctly on v2.0.0-beta2. Can you try it there? |
Related but not the same as #5
|
Oh interesting! Thanks for the screenshot and example log file names. I'll try that out here and see if I can recreate to fix it. Thanks! |
I tried using the same path and filename as stated above and I couldn't get to behave as shown in your screenshot. I'll try running logstation in a docker container to see if it behaves any differently. What browser were you using? I've tried it on the latest Chrome and Firefox, both of which worked as expected. |
I was using Safari.
…________________________________
From: Jon Drews ***@***.***>
Sent: Wednesday, April 12, 2023 5:52:31 PM
To: jdrews/logstation ***@***.***>
Cc: Barry Caruth ***@***.***>; Author ***@***.***>
Subject: Re: [jdrews/logstation] Enhancement - Log Tab Title (Issue #71)
I tried using the same path and filename as stated above and I couldn't get to behave as shown in your screenshot.
I'll try running logstation in a docker container to see if it behaves any differently.
What browser were you using? I've tried it on the latest Chrome and Firefox, both of which worked as expected.
—
Reply to this email directly, view it on GitHub<#71 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAQOKUVLCI7KCGX5RV27GPDXA3MU7ANCNFSM6AAAAAAWVFALAU>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
I was able to reproduce the problem where the logfile gets text-overflow ellipsed on the right side instead of the left. This only seems to happen on Safari. I couldn't get my CSS magic to work on Safari, so instead I'm picking up when it's Safari and only showing the filename and not the path. I made a new beta release. Please try it out and let me know how it goes. |
By the way, do you happen to have a M1 or M2 mac? (darwin_arm64)? I made a build for that but I haven't been able to test it since I don't have access to that type of hardware. |
Apologies for the delay. The new version works perfectly in Safari. I'm afraid my Mac is not Apple silicon. |
Great! Thanks for logging this issue and trying out the fix! I'm going to close this issue out. |
Great project. Thank you.
The tabs for log files display the name truncated from the start of the path. Like "/some/folder/..." but, in my opinion, it would be better to show the end of the path like "../log/service.log" (and truncate at the start).
I know that you can hover over the tab to see the full file path but I thought this might be easier.
Alternatively, it would be cool to provide some way to specify the tab title for a particular log in the config file. This might not work so well for wildcards.
And it would be great if you could specify a tab colour for a particular log (or set of logs).
The text was updated successfully, but these errors were encountered: