Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to override object retrieval in compare_view method. #166

Open
NikAzanov opened this issue Feb 21, 2022 · 1 comment
Open

Comments

@NikAzanov
Copy link

In the BaseCompareVersionAdmin.compare_view method, the current implementation of object retrieval uses get_object_or_404 for the model. This method uses _default_manager, which makes it impossible to work with logically deleted objects. It would be nice to have a separate method for getting an object or something like that, so it can be easily overridden and work with the needed queryset.

@jedie
Copy link
Owner

jedie commented Feb 22, 2022

Pull requests are welcome. Plesse with a complete test ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants