Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new ManyToMany relationship causes exception #38

Open
mopubjesse opened this issue May 12, 2015 · 3 comments
Open

Adding a new ManyToMany relationship causes exception #38

mopubjesse opened this issue May 12, 2015 · 3 comments

Comments

@mopubjesse
Copy link

It seems that adding a new ManyToMany relationship, and then comparing an object seems to cause it to break.

reversion_compare/admin.py:50 sets "Field Didn't exist!" in this case, as the old reversion of the model doesn't have the value, and then reversion_compare/admin.py:124 blows up on that value.

I would propose putting a try/except and return the new list of ids in this case. I'm happy to do a pull-request if you agree this is appropriate.

Thanks.

@jedie
Copy link
Owner

jedie commented May 12, 2015

Pull requests are always welcome ;)

@jedie
Copy link
Owner

jedie commented Jul 24, 2015

@mopubjesse Does this happen in current release? Think #41 has fixed this.

@mopubjesse
Copy link
Author

Awesome. From glancing at the code I'm not sure, I'll have to wire it up and test. I'll try to find time, just about to head out on vacation for 2 weeks. Give me a few weeks once I've gotten back to check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants