Skip to content
This repository has been archived by the owner on Oct 24, 2022. It is now read-only.

Applauding your efforts to update: What are your plans for this version? #4

Closed
jgberg opened this issue Jul 20, 2015 · 7 comments
Closed

Comments

@jgberg
Copy link

jgberg commented Jul 20, 2015

Hi, I, for one, am very glad that you're taking up updating this very important plugin. It would be good if you updated the README to announce your plans or intent.
I'm particularly curious as to whether you will:

  1. add functionality to support full HTTP verbs: e.g. DELETE (which is required to remove Game invites & app requests
  2. Will you support the new Facebook SDK now v2.4
@jeduan
Copy link
Owner

jeduan commented Jul 21, 2015

0: ideally, this would be merged into the main Facebook plugin, however, the team over there doesn't seem to be responding too much to issues lately, and hasn't announced any plan on npm support so I'm a bit on the dark on what's their plan to migrate when the cordova.io repository goes dark on October.
1: Sure, just create an issue with the links to the APIs you want to support, so I can prioritize which features are needed the most
2: Yep

@kaumac
Copy link

kaumac commented Jul 22, 2015

👍 I'm glad someone is continuing the work from the original plugin since this is, in my opinion, one of the most critical/important cordova plugins out there.

The original repository have a lot of issues stacking up and it really doesn't seem to be getting a lot of attention. Thanks and congrats for your work 😄

@hirbod
Copy link
Collaborator

hirbod commented Aug 11, 2015

+1 for DELETE support. But actually, this should be possible with a graph-call either.

I did something like that with an old plugin: (cordova facebook ccsoft, but really, don't try that plugin :D)

$rootScope.facebook.graphCall(
                                    "me/permissions", 
                                    {}, 
                                    "DELETE", 
                                    function(resp) {

                                        localStorageService.clearAll();
                                        appNavigator.resetToPage('login.html');
                                        window.plugins.spinnerDialog.hide();

                                       //console.log("My name is: " + resp.name + " and id is: " + resp.id);
                                       //console.log(resp);
                                   },        
                                    function(a){
                                        localStorageService.clearAll();
                                        appNavigator.resetToPage('login.html');
                                        window.plugins.spinnerDialog.hide();
                                    }
                                );

But as far as I can see, I can't submit "DELETE" to that call, am I right? That would be very bad :(

@hirbod
Copy link
Collaborator

hirbod commented Aug 11, 2015

Nevermind, it is possible. Works like a charm. Thank YOU SO MUCH for this plugin!

                                facebookConnectPlugin.api("me/permissions?method=DELETE", [], 
                                    function(resp) {

                                        localStorageService.clearAll();
                                        appNavigator.resetToPage('login.html');
                                        window.plugins.spinnerDialog.hide();

                                   },        
                                    function(a){
                                        ...
                                    }
                                );

Just submit method as a param (eg DELETE)

@hirbod
Copy link
Collaborator

hirbod commented Aug 11, 2015

Some other suggestions I made to the old facebook plugin maintainer:

  1. support App-Install tracking by default (it's very easy to integrate, just 2 lines of code)
    Support "App-Install Tracking" by default on iOS ccsoft/cordova-facebook#69

  2. [the most important]
    Please provide the native facebook permission alert. "Jumping" around the apps is so ugly and so 2013.
    No native alert dialog ccsoft/cordova-facebook#65

I would love to do this by myself, but I really don't have enough know how on this. I hope we could see some of this features. If you want, I could open an own ticket for my wishes but I thought this thread is a good place for it.

@jeduan
Copy link
Owner

jeduan commented Aug 11, 2015

Thanks for your suggestions @hirbod can you please create a separate issue for each suggestion to have a better tracking?

@hirbod
Copy link
Collaborator

hirbod commented Aug 11, 2015

@jeduan, of course!

@jeduan jeduan closed this as completed Sep 7, 2015
jgiovanni added a commit to jgiovanni/cordova-plugin-facebook4 that referenced this issue Nov 22, 2015
jayj pushed a commit to jayj/cordova-plugin-facebook4 that referenced this issue Mar 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants