Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed test #15

Open
remicollet opened this issue Nov 2, 2013 · 1 comment
Open

Failed test #15

remicollet opened this issue Nov 2, 2013 · 1 comment

Comments

@remicollet
Copy link

1) HTTP_OAuth_MessageTest::testGetParametersIsSorted
Only variables should be passed by reference

/dev/shm/extras/BUILD/php-pear-HTTP-OAuth-0.3.0/HTTP_OAuth-0.3.0/tests/HTTP/OAuth/MessageTest.php:68

Trivial fix.

diff -up HTTP_OAuth-0.3.0/tests/HTTP/OAuth/MessageTest.php.old HTTP_OAuth-0.3.0/tests/HTTP/OAuth/MessageTest.php
--- HTTP_OAuth-0.3.0/tests/HTTP/OAuth/MessageTest.php.old   2013-11-02 07:11:48.511779978 +0100
+++ HTTP_OAuth-0.3.0/tests/HTTP/OAuth/MessageTest.php   2013-11-02 07:11:21.471684361 +0100
@@ -65,7 +65,8 @@ class HTTP_OAuth_MessageTest extends PHP
         $params = array('z' => 'foo', 'a' => 'bar');
         $m = new HTTP_OAuth_MessageMock;
         $m->setParameters($params);
-        $this->assertEquals('bar', reset($m->getParameters()));
+        $param = $m->getParameters();
+        $this->assertEquals('bar', reset($param));
     }

     public function testMagicGetter()
@remicollet
Copy link
Author

I just noticed that this repo only contains version 0.2.3 sources...

Where are the 0.3.0 sources ?
So, the link from pear.php.net probably need to be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant