Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non-numeric data as input #81

Open
jeffreypullin opened this issue Jun 2, 2020 · 6 comments
Open

Allow non-numeric data as input #81

jeffreypullin opened this issue Jun 2, 2020 · 6 comments
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@jeffreypullin
Copy link
Owner

Currently, we demand that all data be numeric - we should relax this to allow for, factors and character vectors etc. The key difficulty of this is how to present the input data in the output.

See discussion in #75 and compare with #70

jeffreypullin added a commit that referenced this issue Jun 2, 2020
We will eventually support non-numeric data (#81) but for now we error.
@jeffreypullin jeffreypullin added this to the future milestone Jun 26, 2020
@jeffreypullin
Copy link
Owner Author

One of the key questions here is how we would label the returned the parameters with the non-numeric input

@Agasax
Copy link

Agasax commented Oct 28, 2020

Just an amateur suggestion, sorry if I'm way off, but would the function recover_types from tidybayes be something to look into?

@jeffreypullin
Copy link
Owner Author

@Agasax Did you find the need to convert everything to numeric a big limitation in your use of {rater}? Implementing non-numeric input is feasible but it would be a lot of work so I'm considering whether it is worth it atm. I'd love to hear your thoughts!

@Agasax
Copy link

Agasax commented Jan 28, 2021

Sorry for slow response here.
The issue was not providing the data in numerical form, but rather not having the factor levels conserved when using the plotting functions of you get my meaning.
I hope to try it out again this weekend, will get back to you.

@jeffreypullin
Copy link
Owner Author

All good! Yes, that's what I meant really 😄

@jeffreypullin
Copy link
Owner Author

Unfortunately this isn't going to make it into the 1.1 release, but I'm going to add it into the 1.2 milestone so that I remember to work on it soon.

@jeffreypullin jeffreypullin modified the milestones: 1.1, 1.2 Feb 18, 2021
@jeffreypullin jeffreypullin added enhancement New feature or request help wanted Extra attention is needed labels Feb 18, 2021
@jeffreypullin jeffreypullin modified the milestones: 1.2, future Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants