Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch progress not updated with intros #355

Open
Lodeli opened this issue Dec 9, 2024 · 2 comments
Open

Watch progress not updated with intros #355

Lodeli opened this issue Dec 9, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Lodeli
Copy link

Lodeli commented Dec 9, 2024

Describe the bug
With intros enabled, the progress of the watched show is not updated.
Continue watching won't show the progress for movies or series and Next Up won't update.

To Reproduce
Configure JellyCon and enable intros.
Play any media through the plugin, movie or series.

Expected behavior
When stopping the show, the Next Up or the Continue watching sections should be updated in Kodi and on the Jellyfin server side.

Screenshots
It seems that JellyCon uses a playlist to play both intro and media file but only info about the first file in the playlist are sent as currently playing.
Here you can see a screenshot from the Jellyfin Server Dashboard: while the movie was playing, the progress kept showing the intro even though it only lasts 11 seconds leading also to a wrong progress time:
Image

System:

  • OS: Fire OS
  • Jellyfin Version: 10.10.3
  • Kodi Version: 21.1.0
  • Addon Version: 0.8.0+py3
@Lodeli Lodeli added the bug Something isn't working label Dec 9, 2024
@Lodeli
Copy link
Author

Lodeli commented Dec 11, 2024

I've just tried to have a look at the code.
It's my first time with python and with Kodi addons in general, so it's very likely I'm totally wrong.

I checked the method send_progress() and it seems to rely on the return value of get_playing_data(), so I tried to check the value of the variable playlist_data_string while playing a random intro and then a media file.

The value contains always one single item: it's always only the intro.
Here an example:
{ "{jellyfin-server}/Videos/3c922ee407bb4883b04d85caad6666ac/stream?static=True&PlaySessionId=cdb857dc175048e7af6adea3be0de4c4&MediaSourceId=3c922ee407bb4883b04d85caad6666ac": { "item_id": "3c922ee407bb4883b04d85caad6666ac", "source_id": "3c922ee407bb4883b04d85caad6666ac", "playback_type": "DirectStream", "play_session_id": "cdb857dc175048e7af6adea3be0de4c4", "play_action_type": "play_all" } }

@Lodeli
Copy link
Author

Lodeli commented Dec 11, 2024

I also checked the variable play_data_string and found a weird behavior.

Its duration property changes while keeping the same item_id.

Before - playing the intro:
{"item_id": "7292f79adc574411a8836da2792b4923", "source_id": "7292f79adc574411a8836da2792b4923", "playback_type": "DirectStream", "play_session_id": "f12d64bea86d4dae865fc98634d64c82", "play_action_type": "play_all", "current_position": -0.099, "duration": 10.048, "currently_playing": true}

After - playing the real media:
{"item_id": "7292f79adc574411a8836da2792b4923", "source_id": "7292f79adc574411a8836da2792b4923", "playback_type": "DirectStream", "play_session_id": "f12d64bea86d4dae865fc98634d64c82", "play_action_type": "play_all", "current_position": -0.099, "duration": 3818.64, "currently_playing": true}

Duration change from 10s to 1h but the item id remains the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant