Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish wheels on pypi #28

Open
douardda opened this issue Oct 31, 2018 · 11 comments
Open

publish wheels on pypi #28

douardda opened this issue Oct 31, 2018 · 11 comments

Comments

@douardda
Copy link

it would be great to have python wheels published on pypi along the source package. Would help CI kind of tasks (especially tests in tox and the like).

@jelmer
Copy link
Owner

jelmer commented Oct 31, 2018

+1 If you're interested in working on this, help would be great.

@jelmer
Copy link
Owner

jelmer commented May 22, 2020

I think the easiest way to do this is to update the appveyor file to install the right dependencies; we already have it set up to build and publish msi and wheel files.

To a large extent, this means adding the steps documented in section E (Building the Latest Source under Windows) in appveyor.yml.

@k10blogger
Copy link

So i setup up the environment. After some struggle. I am getting the following syntax error for the subvertpy-upstream-0.10.1 at util.c at lines
image

Any idea how to resolve this? From my understanding it is assigment to existings variables. So i guess a hopefull guess that .<varible_name> = value, should only be value,.

@jelmer
Copy link
Owner

jelmer commented May 22, 2020

Yeah, some fairly recent versions of MSVC don't support C99 style struct member assignments. Feel free to replace with ordered member values. Note that you can't just drop the ".foo = " bit, you'll need to make sure that they're in the right order as well and that any intermediate member variables are initialized.

@k10blogger
Copy link

I did that now i am stuck at the linking part seems some library mismatch can you help me with that.
From the picture below:
I could not find neon library in the 1.8.17 dev folder. or any 1.8.17 folder.
I removed the libintl completely
image

From image further below
1 - I am able to find these libraries
2 - Removed the intl as not needed and optional
3 - found these in the VC for Python SDK folder
But i cannot find the zlibstat library. Do you know where to look for?
image

@jelmer
Copy link
Owner

jelmer commented May 22, 2020

FWIW that's in the bit of code I have removed from subvertpy, because it's too crufty. I don't think it's useful to try and build subvertpy that way - I'd recommend just building subversion using their instructions and once you've done that, then try and build subvertpy.

@jelmer
Copy link
Owner

jelmer commented May 23, 2020

FWIW I've been moving my projects over to GitHub actions from appveyor/travis.

The .github/workflows/pythonpackage.yml code has the beginnings of this for subvertpy.

@k10blogger
Copy link

Thanks for the information. I am still stuck at building subversion on windows. Reading up on that.

@jelmer
Copy link
Owner

jelmer commented Nov 10, 2020

There is some progress towards this - now merged into master.

The github action will actually build subvertpy on Windows. The modules load, but the testsuite currently crashes.

Once that's addressed, we could potentially use the github actions to publish a wheel on Windows.

@k10blogger
Copy link

Hi It seems from the build history
https://github.com/jelmer/subvertpy/runs/1377423910?check_suite_focus=true

It fails at this action
https://github.com/jelmer/subvertpy/actions/runs/355021529/workflow#L110

msbuild needs a build package like the following on the system like this one
https://visualstudio.microsoft.com/thank-you-downloading-visual-studio/?sku=BuildTools&rel=16

Need to read up on how to get it in the actions or the machine.

@jelmer
Copy link
Owner

jelmer commented Nov 13, 2020

Hmm, odd - that used to work - I've added the missing action to install msbuild.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants