Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LTS Changelog archive page only displays changes since baseline #4524

Open
kmartens27 opened this issue Feb 3, 2025 · 3 comments
Open

LTS Changelog archive page only displays changes since baseline #4524

kmartens27 opened this issue Feb 3, 2025 · 3 comments
Labels
jenkins.io triage Incoming issues that need review

Comments

@kmartens27
Copy link
Collaborator

Service(s)

jenkins.io

Summary

The LTS changelog archive page is currently displaying older LTS changelog entries, but the .1 releases are not fully rendered. It appears that the .1 changelog entries only have the # compared to lts_baseline 2.479 - extracted from the RC commit(s) displayed. This means that any entries included in the second section (lts_changes: # compared to lts_predecessor 2.462.3 (selected by personal review)) are not shown on the archive page.

This image shows the archive page for 2.375.1 (note there are only 3 entries for the whole 2.375.1 changelog):
Image

This image shows that there is at least one entry for 2.375.1 not displayed, with many more also not included.
Image

Additional entries for 2.375.1

Image

I'm not entirely sure what part of the recent changelog archive creation might be causing this, but it could be something that was missed during the review of that pull request.

Reproduction steps

  • Navigate to https://www.jenkins.io/changelog-stable-old/
  • Review any of the x.xxx.1 releases to find that they have minimal entries compared to what should be displayed
  • Compare to content actually stored in the lts.yml changelog file
@kmartens27 kmartens27 added the triage Incoming issues that need review label Feb 3, 2025
@kmartens27
Copy link
Collaborator Author

kmartens27 commented Feb 4, 2025

@biru-codeastromer just wanted to flag this to you as well, would you happen to have any insights as to what might cause this sort of rendering?

@biru-codeastromer
Copy link

@biru-codeastromer just wanted to flag this to you as well, would you happen to have any insights as to what might cause this sort of rendering?

Thanks for flagging this, @kmartens27 Sir ! I’ll take a look at the changelog archive logic and see if anything from my previous PR could have affected the rendering of .1 releases. It seems like entries from lts_changes might not be displaying correctly—I'll investigate and share any insights I find.

@biru-codeastromer
Copy link

@biru-codeastromer just wanted to flag this to you as well, would you happen to have any insights as to what might cause this sort of rendering?

Thanks for reaching out ! Since my PR primarily introduced the archive page while maintaining the existing logic for displaying changelogs, it shouldn’t directly affect how .1 releases are rendered.

However, I did notice that .1 releases might be missing full lts_changes data in lts.yml, which could be affecting their display. If the changelog system only provides a comparison (# compared to lts_baseline) without a full list of changes, that could explain why some entries are missing.

It might be worth checking if .1 releases in site.changelogs[:lts] have the correct data. If not, we may need to adjust how they are structured or fetched. Let me know how I can assist further!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jenkins.io triage Incoming issues that need review
Projects
None yet
Development

No branches or pull requests

2 participants