Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CB maintainers to plugins #2415

Merged
merged 2 commits into from
Feb 28, 2022
Merged

Conversation

Wadeck
Copy link
Collaborator

@Wadeck Wadeck commented Feb 28, 2022

Description

  • As part of @security I auto-approve my changes to all except matrix-auth
  • [ ] matrix-auth requires approval from @daniel-beck => refused

The @security team will keep working on the security aspects of those plugins and additional people will help/contribute.

CC @jtnord @batmat as it's the result of our discussion last week.
CC @Kevin-CB for the addition to the @security team

Plugin repositories:

Submitter checklist for adding or changing permissions

Always

  • Add link to plugin/component Git repository in description above

For a newly hosted plugin only

  • Add link to resolved HOSTING issue in description above

For a new permissions file only

When adding new uploaders (this includes newly created permissions files)

Reviewer checklist (not for requesters!)

  • Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
  • Check that the $pluginId Developers team has Admin permissions while granting the access.
  • In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
  • If security contacts are changed (this includes add/remove), ping the security officer (currently @Wadeck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

@Wadeck Wadeck requested a review from a team as a code owner February 28, 2022 10:05
@timja
Copy link
Member

timja commented Feb 28, 2022

Could you add a checklist against each plugin listing their approvers and approval status please?

@Wadeck
Copy link
Collaborator Author

Wadeck commented Feb 28, 2022

Added checklist + approval from me as maintainer of the plugins in modified files.

@timja timja merged commit f18b3f5 into jenkins-infra:master Feb 28, 2022
@timja
Copy link
Member

timja commented Feb 28, 2022

will you handle the permissions or need someone to do for you?

@Wadeck
Copy link
Collaborator Author

Wadeck commented Feb 28, 2022

@timja Never used the bot before, so if it's straightforward please do so, otherwise point me to the doc please :)

@timja
Copy link
Member

timja commented Feb 28, 2022

https://www.jenkins.io/projects/infrastructure/ircbot/

jenkins-admin: Grant USER a commit access of/to REPO

e.g. a recent one:

jenkins-admin: make mhmdabdh a committer on global-post-script-plugin

in #jenkins-hosting

@Wadeck
Copy link
Collaborator Author

Wadeck commented Feb 28, 2022

Thanks, will do it after lunch 👍

@batmat
Copy link
Contributor

batmat commented Nov 26, 2024

FTR, I've added the CB dev team as maintainer, to reflect the approval conveyed in this PR. This was apparently forgotten on GH side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants