Adding capability to configure private Route53 domains #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ok-to-test |
|
I think I have a bug with the for_each, when we don't want to create the associated vpns |
chrislovecnm
force-pushed
the
private-dns
branch
3 times, most recently
from
feb93c2
to
79b11b0
Compare
At times a user will want to configure private Route53 domains. This introduces the capbility to set a flag and have terraform create the private Route53 DNS entries. This feature is useful to configure such things as split DNS and also allow for private DNS entries for such things as nexus and chartmuseum.
ankitm123
reviewed
May 25, 2022
| @@ -15,6 +15,28 @@ resource "aws_route53_zone" "subdomain_zone" { | |||
| force_destroy = var.force_destroy_subdomain | |||
| } | |||
|
|
|||
| resource "aws_route53_zone" "private_zone" { | |||
|
|
|||
|
|
||
| resource "aws_route53_zone_association" "secondary" { | ||
| zone_id = aws_route53_zone.private_zone[0].zone_id | ||
| for_each = tomap(var.private_dns_associated_vpc_ids) |
There was a problem hiding this comment.
do u need tomap when private_dns_associated_vpc_ids is a map?
ankitm123
reviewed
May 26, 2022
| } | ||
|
|
||
| resource "aws_route53_zone_association" "secondary" { | ||
| zone_id = aws_route53_zone.private_zone[0].zone_id |
There was a problem hiding this comment.
probably better to use element?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At times a user will want to configure private Route53 domains.
This introduces the capability to set a flag and have terraform
create the private Route53 DNS entries.
This feature is useful to configure such things as split DNS and
also allow for private DNS entries for such things as nexus and
chartmuseum.
Notes for reviewers
I have not checked the use case where we are creating the VPC itself. How would I get the vpc id then?
Which issue this PR fixes
fixes #349
Release notes
New flag added to allow for the create a private Route53 domain. Set
create_and_configure_private_subdomainto trueand this module will create and manage the private domain.