Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add emitConfigChangeEvents option back #373

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Add emitConfigChangeEvents option back #373

merged 1 commit into from
Nov 16, 2023

Conversation

sarah-witt
Copy link
Collaborator

@sarah-witt sarah-witt commented Nov 15, 2023 •
edited
Loading

What does this PR do?

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@sarah-witt sarah-witt added the changelog/Fixed Fixed features results into a bug fix version bump label Nov 15, 2023
@sarah-witt sarah-witt changed the title Add config changed events param bacl Add emitConfigChangeEvents option back Nov 15, 2023
@sarah-witt sarah-witt marked this pull request as ready for review November 15, 2023 18:52
@sarah-witt sarah-witt merged commit f012205 into master Nov 16, 2023
13 of 17 checks passed
@sarah-witt sarah-witt deleted the sarah/add-config-var-back branch November 16, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jose-manuel-almaza jose-manuel-almaza jose-manuel-almaza approved these changes

Assignees
No one assigned
Labels
changelog/Fixed Fixed features results into a bug fix version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid configuration elements emitConfigChangeEvents
2 participants
@sarah-witt @jose-manuel-almaza