Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stack overflow on initialising DatadogTaskListenerDecorator #396

Conversation

nikita-tkachenko-datadog
Copy link
Collaborator

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

Fixes stack overflow on initialising DatadogTaskListenerDecorator:

  1. BuildData instance construction is started
  2. EnvActionImpl#getEnvironment() is called
  3. Inside this call run's TaskListener is initialized
  4. Once TaskListener is created, it is wrapped with DatadogTaskListenerDecorator
  5. The decorator starts creating another BuildData instance
  6. The steps repeat indefinitely from point 1

The example stack trace can be found here.

The EnvActionImpl#getEnvironment() call is replaced with EnvActionImpl#getOverriddenEnvironment(), which only returns the env vars that were overridden in that action.
The latter call does not trigger task listener initialisation, and allows to examine the right env vars.

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@nikita-tkachenko-datadog nikita-tkachenko-datadog added the changelog/Fixed Fixed features results into a bug fix version bump label Feb 7, 2024
@nikita-tkachenko-datadog nikita-tkachenko-datadog marked this pull request as ready for review February 7, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/Fixed Fixed features results into a bug fix version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StackOverflowError after enabling log collection
2 participants