Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update strings to be more pythonic - use f-strings #104

Closed
intendo opened this issue Nov 22, 2020 · 4 comments
Closed

Update strings to be more pythonic - use f-strings #104

intendo opened this issue Nov 22, 2020 · 4 comments
Assignees

Comments

@intendo
Copy link

intendo commented Nov 22, 2020

Update all strings to use f-strings rather than using str.format syntax

@sobolevnrm
Copy link
Collaborator

@speleo3 @orbeckst -- I think one of you suggested this before. Do you concur?

@IAlibay
Copy link
Contributor

IAlibay commented Nov 22, 2020

Probably worth mentioning this, some very small parts of the codebase now use f-strings as of #85 and #84.

May I suggest taking a strategy where type hinting & f-strings are added progressively as API docs are completed (say for something like #98)?

@speleo3
Copy link
Collaborator

speleo3 commented Nov 23, 2020

I like f-strings and certainly use them in new code when possible. But updating existing code with a new pattern is usually low priory for me and it comes with an inherit risk for regressions.

@intendo
Copy link
Author

intendo commented Jan 26, 2022

Closing issue due to lack of progress and I agree with @speleo3 and @IAlibay that this can be done incrementally over time.

@intendo intendo closed this as completed Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants