Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider eliminating propka/version.py #188

Open
speleo3 opened this issue Feb 4, 2024 · 0 comments
Open

Consider eliminating propka/version.py #188

speleo3 opened this issue Feb 4, 2024 · 0 comments

Comments

@speleo3
Copy link
Collaborator

speleo3 commented Feb 4, 2024

Quoting Nathan (9826351 May 2020):

TODO - this module unnecessarily confuses the code. Can we eliminate it?

propka/version.py provides an abstract Version class and several subclass implementations. The only implementation that we currently use is VersionA, which gets selected from propka.cfg. It's unclear whether the other implementations are even working and there is neither documentation nor example code for how and why to use them.

API doc: https://propka.readthedocs.io/en/latest/api/propka.version.html

See also #179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant