Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ad hoc list in groups.py #54

Open
sobolevnrm opened this issue May 30, 2020 · 1 comment
Open

Replace ad hoc list in groups.py #54

sobolevnrm opened this issue May 30, 2020 · 1 comment
Assignees
@sobolevnrm
Labels
refactoring

Comments

@sobolevnrm
Copy link
Collaborator

The list ['sidechain', 'backbone', 'coulomb'] appears in several places in groups.py but could be replaced with the keys of Groups.determinants.

https://github.com/jensengroup/propka-3.1/blob/dde0d67ea5d7b0e8b24a3050ae4d6cbc4ca07972/propka/group.py#L145
@orbeckst
Copy link
Collaborator

I am always in favor of DRY code.

@sobolevnrm sobolevnrm self-assigned this Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevnrm sobolevnrm

Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@orbeckst @sobolevnrm