Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate --file option #90

Open
speleo3 opened this issue Jul 21, 2020 · 0 comments
Open

Deprecate --file option #90

speleo3 opened this issue Jul 21, 2020 · 0 comments
Assignees

Comments

@speleo3
Copy link
Collaborator

speleo3 commented Jul 21, 2020

The -f FILENAMES option is redundant with the input_pdb option, except that the former is optional and allows multiple files, and the latter is mandatory and only allows a single file.

I suggest to deprecate the -f and --file arguments and turn input_pdb into an nargs='+' option.

There is one more difference: input_pdb is only added if build_parser creates a new parser, but not if it creates a subparser. The --file option is always added. I don't know if this is relevant.

@sobolevnrm sobolevnrm self-assigned this Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants