test-uds-connect assertion is vacuous; runner is a hardcoded list

[jeonghanlee]

test-uds-connect assertion is vacuous; runner is a hardcoded list

Milestone

Backlog

Labels

bug, P2-medium

Summary

tests/test-uds-connect.bash does not actually assert that a connect happened, so it passes unconditionally — it would report green with the #4 bug present. Two defects stack: run_con (tests/test-common.bash) ends on rm -f and captures output with || true, so it always returns 0; and the test checks $? after an intervening connect_ok="false" assignment, so $? reflects the assignment, not the run. Consequently "UDS suite green" carries no information for the connect case. Separately, tests/run-all-tests.bash advertises auto-discovery in its header but runs a hardcoded _run_test list, so a new test file is silently skipped unless the list is edited.

Root Cause

tests/test-common.bash:192,196; tests/test-uds-connect.bash:26-29; tests/run-all-tests.bash:4,89-99.

Proposed Fix

Rewrite the connect assertion to a real behavioral check (echo round-trip, as in test-uds-echo.bash); make run_con propagate the real status; and either implement the advertised auto-discovery in the runner or correct the header comment to match the hardcoded list.

Acceptance Criteria

• A deliberately broken connect (or a misroute) makes the connect suite fail.
• A newly added test-*.bash is executed by make test without a separate registration step, or the runner's documentation matches its actual behavior.

Out of Scope

The #4 fix. M1 adds one self-contained real assertion for its own change; this issue repairs the suite's general connect-coverage integrity.

Surfaced during the M1 (#4) review session, 2026-06-22 (Reviewer 4).