Skip to content

v2: extract split/drop-cycle helpers from cellreader (V2-09 follow-up) #519

Description

@jepegit

V2-09 continuation (epic #402; follow-up from #509). Target branch: master.

Extract the split/drop-cycle helpers from cellreader.py (twice-flagged
# TODO: consider moving splitting etc outside of CellpyCell):
mod_raw_split_cycle, split, drop_from, drop_to, from_cycle,
to_cycle, drop_edges, split_many, with_cycles.

Follow the #509 pattern (cellpy/readers/capacity_curves.py): verbatim move
into e.g. cellpy/readers/slicing.py, instance-first functions, thin
delegates, behaviour unchanged. Check existing test coverage of
split/split_many/with_cycles before moving; add pins where thin.

Metadata

Metadata

Assignees

No one assigned

    Labels

    v2cellpy v2.0 epic work - PRs should target the master branch

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions