Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FP]: False positive for CVE-2024-35255 in com.microsoft.azure/[email protected] #6840

Open
juanmanuelromeraferrio opened this issue Jul 15, 2024 · 8 comments
Labels
FP Report maven changes to the maven plugin

Comments

@juanmanuelromeraferrio
Copy link

juanmanuelromeraferrio commented Jul 15, 2024

Package URl

pkg:maven/com.microsoft.azure/[email protected]

CPE

cpe:2.3:a:microsoft:authentication_library:1.15.1:::::::*

CVE

CVE-2024-35255

ODC Integration

{"label"=>"CLI"}

ODC Version

10.0.2

Description

The msal4j library version 1.15.1 is marked as excluded for CVE-2024-35255, but is still being reported as vulnerable. This appears to be a false positive, as the vulnerability should not apply to versions 1.15.1 and above.

Copy link
Contributor

Maven Coordinates

<dependency>
   <groupId>com.microsoft.azure</groupId>
   <artifactId>msal4j</artifactId>
   <version>1.15.1</version>
</dependency>

Suppression rule:

<suppress base="true">
   <notes><![CDATA[
   FP per issue #6840
   ]]></notes>
   <packageUrl regex="true">^pkg:maven/com\.microsoft\.azure/msal4j@.*$</packageUrl>
   <cpe>cpe:/a:microsoft:authentication_library</cpe>
</suppress>

Link to test results: https://github.com/jeremylong/DependencyCheck/actions/runs/9941860681

@github-actions github-actions bot added the maven changes to the maven plugin label Jul 15, 2024
@juanmanuelromeraferrio juanmanuelromeraferrio changed the title [FP]: [FP]: False positive for CVE-2024-35255 in com.microsoft.azure/[email protected] Jul 15, 2024
Copy link
Contributor

Maven Coordinates

<dependency>
   <groupId>com.microsoft.azure</groupId>
   <artifactId>msal4j</artifactId>
   <version>1.15.1</version>
</dependency>

Suppression rule:

<suppress base="true">
   <notes><![CDATA[
   FP per issue #6840
   ]]></notes>
   <packageUrl regex="true">^pkg:maven/com\.microsoft\.azure/msal4j@.*$</packageUrl>
   <cpe>cpe:/a:microsoft:authentication_library</cpe>
</suppress>

Link to test results: https://github.com/jeremylong/DependencyCheck/actions/runs/9941871855

Copy link
Contributor

Maven Coordinates

<dependency>
   <groupId>com.microsoft.azure</groupId>
   <artifactId>msal4j</artifactId>
   <version>1.15.1</version>
</dependency>

Suppression rule:

<suppress base="true">
   <notes><![CDATA[
   FP per issue #6840
   ]]></notes>
   <packageUrl regex="true">^pkg:maven/com\.microsoft\.azure/msal4j@.*$</packageUrl>
   <cpe>cpe:/a:microsoft:authentication_library</cpe>
</suppress>

Link to test results: https://github.com/jeremylong/DependencyCheck/actions/runs/9941886001

@matthiaskraaz
Copy link

Not good. This also suppresses true positives.

The match to cpe:/a:microsoft:authentication_library:::~~~node.js~~ and cpe:/a:microsoft:authentication_library:::~~~.net~~ respectively cpe:2.3:a:microsoft:authentication_library:*:*:*:*:*:node.js:*:* and cpe:2.3:a:microsoft:authentication_library:*:*:*:*:*:.net:*:* should be suppressed, while the match to cpe:/a:microsoft:authentication_library:::~~~java~~ respectively cpe:2.3:a:microsoft:authentication_library:*:*:*:*:*:java:*:* must be kept.

What is the correct syntax in suppressions.xml for that? Thanks in advance for your help.

BTW: Does suppressions.xml really only accept CPE 2.2 and not CPE 2.3? Would be nice to have CPE 2.3 in suppressions.xml, so it is aligned with the report.

@juanmanuelromeraferrio
Copy link
Author

Hi,

Thank you for your response. I just wanted to report that the msal4j library version 1.15.1 is incorrectly marked as vulnerable to CVE-2024-35255, which appears to be a false positive. I did not intend to propose a specific suppression solution.

Could you please advise on how to proceed or if there are any additional steps I need to take to ensure this false positive is properly handled?

Thank you in advance for your help.

@trask
Copy link

trask commented Jul 24, 2024

I had similar finding to @matthiaskraaz, which is that libraries/versions for other languages (e.g. Python and JavaScript) are getting matched

@vil2be
Copy link

vil2be commented Aug 14, 2024

Hi, is there any update on this?

@denAbramoff
Copy link

Any news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FP Report maven changes to the maven plugin
Projects
None yet
Development

No branches or pull requests

5 participants