-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RevitRibbonControl non-public break main Ribbon. #292
Comments
Most likely the private members contain a method or property that causes this glitch. Which does not return a value, but changes something in the normal behavior. The only thing to do is to figure out what the method is and forcibly disable it |
The void methods is ignore right? |
Yes, but we have a methods like |
The Here is a quick command to break the Revit ribbon. [Transaction(TransactionMode.Manual)]
public class Command : IExternalCommand
{
public Result Execute(ExternalCommandData commandData, ref string message, ElementSet elementSet)
{
var ribbon = UIFramework.RevitRibbonControl.RibbonControl;
var type = ribbon.GetType();
var method = type.GetMethod("Enter", System.Reflection.BindingFlags.NonPublic | System.Reflection.BindingFlags.Instance); // System.Windows.Media.Visual
var result = method.Invoke(ribbon, null);
Console.WriteLine($"{method} \t {result}");
return Result.Succeeded;
}
} |
Maybe the methods should be only executed if the use click, is related to this issue as well: #239 |
Yes, I plan to take the Lookup engine out as a new project and develop it separately, it will be easier to test and implement such functionality. It will be possible to add Lazy evaluation and Force evaluation for similar cases |
Oh great, thanks for research 🎉 |
RevitLookup version
2025.0.9
Steps to reproduce
If the option
non-public
is enable in RevitLookup and you snoop theRibbon
inside theComponent manager
the main Revit ribbon stop working.Here is a video: RevitLookup - Snoop RevitRibbonControl breaks main Ribbon.
I don't know yet what specific
non-public
member inRevitRibbonControl
that is breaking the UI, gonna make some tests later.The text was updated successfully, but these errors were encountered: