Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-informative messages if the used index is damaged (libc++abi: terminating due to uncaught exception of type std::length_error: vector) #42

Open
karel-brinda opened this issue Nov 7, 2024 · 2 comments

Comments

@karel-brinda
Copy link
Contributor

karel-brinda commented Nov 7, 2024

When using Fulgor in large-scale projects and eg copy / download of an index fails from any reason, Fulgor prints a message that's difficult to trace down to the original issue, e.g.,

libc++abi: terminating due to uncaught exception of type std::length_error: vector

It would be extremely helpful if it could print something like "Error: Index corrupted" or "Error: Index loading failed" or something similar.

@rob-p
Copy link
Collaborator

rob-p commented Nov 7, 2024

Hi @karel-brinda,

Thanks for the suggestion! Actually @jermp --- the more I think about it (and given how helpful it has been in my other work in different aspects), it would be incredibly useful to have some sort of signature/checksum for the index. That is, we could compute the signature of the valid index upon the termination of construction, and store this value in the index itself. It would then be possible to have e.g. a verify command that ensures that someone has the index they believe they have (and that it is not corrupted).

@jermp
Copy link
Owner

jermp commented Nov 7, 2024

Thanks Karel and Rob for your thoughts. Yes, I agree and will add something soon!
Also ping: @Alessio-Campa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants