error editing config

[pixx1]

Hi there!
First, thanks for the nice tool!

I run into the issue when I tried to change the configure.
By pressing "o" i get the error

"exec: "sh": executable file not found in $PATH

Did i missed something? I'm using lazydocker in a docker.

System:
lazyteam/lazydocker:latest
ubuntu 18.04
docker: Docker version 19.03.2, build 6a30dfc

Thanks!
pix_1

EDIT:
This not happen when using the binary version.

[dawidd6]

@qdm12 any ideas on that?

[qdm12]

It's because the binary is on a Scratch image so there is no shell. What program does lazydocker use to modify the configure? Maybe we can incorporate it in Go? Otherwise we can have the go binary on Alpine which should solve the problem but it's less fancy.

[dawidd6]

lazydocker/pkg/commands/os.go

Lines 127 to 168 in a3b3c94

	// OpenFile opens a file with the given
	func (c *OSCommand) OpenFile(filename string) error {
	commandTemplate := c.Config.UserConfig.OS.OpenCommand
	templateValues := map[string]string{
	"filename": c.Quote(filename),
	}
	command := utils.ResolvePlaceholderString(commandTemplate, templateValues)
	err := c.RunCommand(command)
	return err
	}
	// OpenLink opens a file with the given
	func (c *OSCommand) OpenLink(link string) error {
	commandTemplate := c.Config.UserConfig.OS.OpenLinkCommand
	templateValues := map[string]string{
	"link": c.Quote(link),
	}
	command := utils.ResolvePlaceholderString(commandTemplate, templateValues)
	err := c.RunCommand(command)
	return err
	}
	// EditFile opens a file in a subprocess using whatever editor is available,
	// falling back to core.editor, VISUAL, EDITOR, then vi
	func (c *OSCommand) EditFile(filename string) (*exec.Cmd, error) {
	editor := c.getenv("VISUAL")
	if editor == "" {
	editor = c.getenv("EDITOR")
	}
	if editor == "" {
	if err := c.RunCommand("which vi"); err == nil {
	editor = "vi"
	}
	}
	if editor == "" {
	return nil, errors.New("No editor defined in $VISUAL or $EDITOR")
	}
	return c.PrepareSubProcess(editor, filename), nil
	}

c.Config.UserConfig.OS.OpenCommand defaults to xdg-open on linux.

[qdm12]

Maybe put a statically built xdg-open binary next to lazydocker in the scratch image? I'm away from keyboard but I'll check later.

EDIT: I'm looking into it now, I might have an ugly solution to copy paste xdg-open from an Alpine image to /bin.

[qdm12]

When you try to edit the configuration with e, it also fails with this error. I will try to add a static build of vi to see if it works out.

Concerning o to open the config file, I end up here but I'm not sure where to look now, some help would be appreciated 😄

Should we simply let the user modify the config by bind mounting it on the Docker host?

[jesseduffield]

@qdm12 I think bind mounting is a good solution.

As for your question about the OpenFile config option, happy to give guidance but I'm not sure what you're looking for haha

[meteoro]

Open in nano or vim?

[mark2185]

@meteoro could you please clarify what is the question?