Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit and Review PRs #3639

Open
4 tasks
mchisolm0 opened this issue Jun 5, 2024 · 3 comments
Open
4 tasks

Submit and Review PRs #3639

mchisolm0 opened this issue Jun 5, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@mchisolm0
Copy link

Is your feature request related to a problem? Please describe.
No, just would love not having to leave Lazygit. 😊

Describe the solution you'd like
I would like a method of reviewing and submitting PRs similar to the GitHub PR extension from Microsoft (link: https://github.com/microsoft/vscode-pull-request-github).

Describe alternatives you've considered

Additional context
I would like being able to do the following without leaving Lazygit:

  • View a list of pending PRs
  • Select a PR to review
  • See the details of the PR (view diffs and any comments)
  • Add general and/or line specific comments
  • See reviewers needed and how many have reviewed
  • See test status
  • Create a PR

Possible steps:

  • Setup GitHub auth
  • Design rough layout (start with Lazygit layout
  • Retrieve and display list of PRs
  • Design rough PR details (diffs, general comments, button to approve)

Happy to help with this, but I realize it may not make since in Lazygit.

@mchisolm0 mchisolm0 added the enhancement New feature or request label Jun 5, 2024
@mchisolm0
Copy link
Author

I don't think I made clear in the issue, so I wanted to here. I know this would be a lot, so I would love to build this out myself (never used Go before like the template mentioned).

My main question is, does this make sense in the context of Lazygit? I could see it needing to be a separate project due to the complexity.

@carmen-gh
Copy link

there is also gh-dash https://github.com/dlvhdr/gh-dash which can do this. you can also combine it with lazygit and neovim

@mathieurousseau
Copy link

mathieurousseau commented Aug 19, 2024

This!

I am switching from VsCode to nvim and lazygit.

The Github Pull Request plugins in VsCode is so great, I wish this comes to LazyGit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants