-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SelectedSubCommit is nil in the commits tab #3663
Comments
Now, it is a problem that the I'm actually wondering why we need different variables |
I agree. It would be good to do the same with SelectedPath (which currently only refers to the files panel and does not include the commit files panel). Of course for backwards compatibility we'd want to keep the existing keys (though I think it's fine to repurpose SelectedFile and SelectedPath without introducing new keys for those) |
@jesseduffield This works for This would just be for cosmetics, since it's not possible to define a single custom command that works for both local branches and remote branches (although I sometimes wished it was possible to say The only case where it is really needed to make things work is SelectedCommit, as far as I can see. |
Ah interesting. Yeah if we're dealing with two different types, then let's just leave those as-is. If we're dealing with a string let's be general. For the record I bet that users only really care about branch names, commit hashes, and file paths (all strings).
I agree |
Describe the bug
Title
To Reproduce
Expected behavior
SelectedSubCommit should not be null
Screenshots
![image_2024-06-14_22-19-28](https://private-user-images.githubusercontent.com/29950594/339885319-31e184cb-287a-4a34-b772-2bbe1e17c3b1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk3NTU3ODgsIm5iZiI6MTcxOTc1NTQ4OCwicGF0aCI6Ii8yOTk1MDU5NC8zMzk4ODUzMTktMzFlMTg0Y2ItMjg3YS00YTM0LWI3NzItMmJiZTFlMTdjM2IxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MzAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjMwVDEzNTEyOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTFmZWMwMTNlMTYwNGZlNGJhYmQ0MmU2YzA4NzgxMTkwNzZmMGUzMWU3ODEwNzdlMGY2YTAxNTM2ZmI4NTdjYjkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.kF2qHvAHyybEukZItzmU-AyUNxn_HQgJWTeGeUpEj0A)
Version info:
commit=v0.42.0, build date=2024-05-19T10:54:29Z, build source=binaryRelease, version=0.42.0, os=linux, arch=amd64, git version=2.45.1
The text was updated successfully, but these errors were encountered: