lib/sqlite_extensions-uuid.rb, more rubocop

Author: jethrodaniel

.rubocop.yml

@@ -1,15 +1,18 @@
-AllCops:
-  TargetRubyVersion: 3.0
+require:
+  - standard
+  - rubocop-rspec
+  - rubocop-rake
+  - rubocop-performance
 
-Style/StringLiterals:
-  EnforcedStyle: double_quotes
+inherit_gem:
+  standard: config/base.yml
 
-Style/StringLiteralsInInterpolation:
-  EnforcedStyle: double_quotes
+AllCops:
+  NewCops: enable
+  TargetRubyVersion: 3.0
 
-Style/Documentation:
+RSpec/MultipleExpectations:
   Enabled: false
 
-Metrics:
-  Exclude:
-    - 'test/test_*.rb'
+RSpec/ExampleLength:
+  Max: 25

Gemfile.lock

@@ -18,6 +18,7 @@ GEM
       reline (>= 0.4.2)
     json (2.7.2)
     language_server-protocol (3.17.0.3)
+    lint_roller (1.1.0)
     mini_portile2 (2.8.8)
     parallel (1.26.3)
     parser (3.3.5.0)
@@ -60,9 +61,28 @@ GEM
       unicode-display_width (>= 2.4.0, < 3.0)
     rubocop-ast (1.32.3)
       parser (>= 3.3.1.0)
+    rubocop-performance (1.23.1)
+      rubocop (>= 1.48.1, < 2.0)
+      rubocop-ast (>= 1.31.1, < 2.0)
+    rubocop-rake (0.6.0)
+      rubocop (~> 1.0)
+    rubocop-rspec (3.4.0)
+      rubocop (~> 1.61)
     ruby-progressbar (1.13.0)
     sqlite3 (2.4.0)
       mini_portile2 (~> 2.8.0)
+    standard (1.35.0.1)
+      language_server-protocol (~> 3.17.0.2)
+      lint_roller (~> 1.0)
+      rubocop (~> 1.62)
+      standard-custom (~> 1.0.0)
+      standard-performance (~> 1.3)
+    standard-custom (1.0.2)
+      lint_roller (~> 1.0)
+      rubocop (~> 1.50)
+    standard-performance (1.6.0)
+      lint_roller (~> 1.1)
+      rubocop-performance (~> 1.23.0)
     stringio (3.1.1)
     unicode-display_width (2.6.0)
 
@@ -74,8 +94,11 @@ DEPENDENCIES
   rake
   rake-compiler
   rspec
-  rubocop
+  rubocop-performance
+  rubocop-rake
+  rubocop-rspec
   sqlite_extensions-uuid!
+  standard
 
 BUNDLED WITH
    2.5.21

Rakefile

@@ -9,15 +9,12 @@ RuboCop::RakeTask.new
 require "rspec/core/rake_task"
 RSpec::Core::RakeTask.new(:spec)
 
-task build: :compile
-
-GEMSPEC = Gem::Specification.load(Dir.glob("*.gemspec").first)
-
-Rake::ExtensionTask.new("sqlite_extensions/uuid", GEMSPEC) do |ext|
+Rake::ExtensionTask.new("sqlite_extensions/uuid") do |ext|
   ext.name = "uuid"
   ext.lib_dir = "lib/sqlite_extensions/uuid"
 end
 
+desc "Update vendored SQLite files"
 task :update do
   sh "wget https://sqlite.org/2024/sqlite-autoconf-3460100.tar.gz"
   sh "tar xvf sqlite-autoconf-3460100.tar.gz"
@@ -28,6 +25,7 @@ task :update do
   sh "mv -v ./uuid.c ext/sqlite_extensions/uuid/"
 end
 
+desc "Run specs"
 task spec: :compile
 
 task default: %i[clobber compile spec rubocop]

lib/sqlite_extensions-uuid.rb

@@ -0,0 +1 @@
+require "sqlite_extensions/uuid"

spec/spec_helper.rb

@@ -6,3 +6,5 @@
   config.order = :random
   Kernel.srand config.seed
 end
+
+require "sqlite_extensions-uuid"

spec/sqlite_spec.rb renamed to spec/sqlite_extensions/sqlite_spec.rb

@@ -1,13 +1,14 @@
 # frozen_string_literal: true
 
-require "sqlite_extensions/uuid"
-
-# NOTE: `sqlite3` isn't required by our gem, but we need it for these tests.
+# not required by our gem, but needed for these tests
 require "sqlite3"
 
-RSpec.describe "Sqlite3 usage" do
+RSpec.describe "Sqlite3 usage" do # rubocop:disable RSpec/DescribeClass
   before do
-    gemspec = instance_double(Gem::Specification, require_path: File.join(__dir__, "../lib"))
+    gemspec = instance_double(
+      Gem::Specification,
+      require_path: File.join(__dir__, "../../lib")
+    )
     allow(Gem).to receive(:loaded_specs).and_return("sqlite_extensions-uuid" => gemspec)
   end
 

spec/uuid_spec.rb renamed to spec/sqlite_extensions/uuid_spec.rb

@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
-require "sqlite_extensions/uuid"
-
-RSpec.describe SqliteExtensions::UUID do # rubocop:disable Metrics/BlockLength
+RSpec.describe SqliteExtensions::UUID do
   it "has a version" do
     expect(described_class::VERSION).to eq "1.0.1"
   end
@@ -14,14 +12,14 @@
     end
 
     it "returns the path to the compiled extension" do
-      path = SqliteExtensions::UUID.to_path
+      path = described_class.to_path
 
       expect(path).to eq "foo/sqlite_extensions/uuid/uuid"
     end
   end
 
   it "has the correct gemspec info" do
-    path = File.expand_path("../sqlite_extensions-uuid.gemspec", __dir__)
+    path = File.expand_path("../../sqlite_extensions-uuid.gemspec", __dir__)
     gemspec = Gem::Specification.load path
 
     expect(gemspec).to have_attributes(
@@ -32,6 +30,7 @@
         ext/sqlite_extensions/uuid/sqlite3.h
         ext/sqlite_extensions/uuid/sqlite3ext.h
         ext/sqlite_extensions/uuid/uuid.c
+        lib/sqlite_extensions-uuid.rb
         lib/sqlite_extensions/uuid.rb
         lib/sqlite_extensions/uuid/version.rb
       ],

sqlite_extensions-uuid.gemspec

@@ -13,13 +13,7 @@ Gem::Specification.new do |spec|
   spec.license = "MIT"
   spec.required_ruby_version = ">= 3.0.0"
 
-  spec.files = %w[
-    lib/sqlite_extensions/uuid.rb
-    lib/sqlite_extensions/uuid/version.rb
-    ext/sqlite_extensions/uuid/sqlite3ext.h
-    ext/sqlite_extensions/uuid/sqlite3.h
-    ext/sqlite_extensions/uuid/uuid.c
-  ]
+  spec.files = Dir.glob("lib/**/*.rb") + Dir.glob("ext/**/*.{c,h}")
   spec.require_paths = ["lib"]
   spec.extensions = ["ext/sqlite_extensions/uuid/extconf.rb"]
 
@@ -29,5 +23,8 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rake-compiler"
   spec.add_development_dependency "rspec"
-  spec.add_development_dependency "rubocop"
+  spec.add_development_dependency "standard"
+  spec.add_development_dependency "rubocop-rake"
+  spec.add_development_dependency "rubocop-rspec"
+  spec.add_development_dependency "rubocop-performance"
 end