From 617056806e17b47739ac8ed747adc1f7ade09962 Mon Sep 17 00:00:00 2001 From: Carson Anderson Date: Mon, 18 Jun 2018 16:19:52 -0600 Subject: [PATCH] Pass the ingress object, not the function to renew This fixes auto-renewal of certificates and exposes any future errors. --- pkg/kubelego/kubelego.go | 4 +++- pkg/kubelego/watch.go | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/pkg/kubelego/kubelego.go b/pkg/kubelego/kubelego.go index d2331ab0..0de77a82 100644 --- a/pkg/kubelego/kubelego.go +++ b/pkg/kubelego/kubelego.go @@ -147,7 +147,9 @@ func (kl *KubeLego) Init() { go func() { for timestamp := range ticker.C { kl.Log().Infof("Periodically check certificates at %s", timestamp) - kl.requestReconfigure() + if err := kl.requestReconfigure(); err != nil { + kl.Log().Errorf("Error requesting reconfigure of certificates: %s", err) + } } }() diff --git a/pkg/kubelego/watch.go b/pkg/kubelego/watch.go index d63bf842..147de068 100644 --- a/pkg/kubelego/watch.go +++ b/pkg/kubelego/watch.go @@ -35,7 +35,7 @@ func (kl *KubeLego) requestReconfigure() error { return err } for _, ing := range allIng { - key, err := cache.MetaNamespaceKeyFunc(ing.Object) + key, err := cache.MetaNamespaceKeyFunc(ing.Object()) if err != nil { return err }