Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Using wrong tag list path for GitHub Enterprise GHCR. #292

Open
Jaypers opened this issue Nov 4, 2024 · 1 comment
Open

[BUG] Using wrong tag list path for GitHub Enterprise GHCR. #292

Jaypers opened this issue Nov 4, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@Jaypers
Copy link

Jaypers commented Nov 4, 2024

Bug Description
With GitHub Enterprise Container Registry the wrong path is used to query tags.
i.e. /v2/<REPO>/<CONTAINER> instead of /v2/<ORG>/<REPO>/<CONTAINER>

Incorrect path can be seen in the error log when purposefully setting the incorrect ghcr.token:

msg="error syncing 'connect-httpsink-0/confluent':
  failed to sync pod confluent/connect-httpsink-0:
    failed to check container image \"connect-httpsink\":
      failed to get tags from remote registry for \"containers.example.com/ORG/container-proxy/connect-custom-http-sink\": 
        failed to get docker image: 
          Get \"https://containers.example.com/v2/container-proxy/connect-custom-http-sink/tags/list?n=500\": 

Path should be:

          Get \"https://containers.example.com/v2/ORG/container-proxy/connect-custom-http-sink/tags/list?n=500\": 

Expected behavior
The "ORG" is taken from the registry URL and placed after /v2/ for the tag query.

Environment:

  • Version-Checker: v0.8.3
  • Kubernetes: v1.30.3
  • Grafana: v11.1.0
  • Prometheus: v2.45.0

Trying to configure self-hosted registry for GHCR we get invalid token
Is there a workaround we could try in the meantime?

@Jaypers Jaypers added the bug Something isn't working label Nov 4, 2024
@Jaypers Jaypers changed the title [BUG] Self-hosted GHCR using wrong tag list path. [BUG] GitHub Enterprise GHCR using wrong tag list path. Nov 4, 2024
@Jaypers Jaypers changed the title [BUG] GitHub Enterprise GHCR using wrong tag list path. [BUG] Using wrong tag list path for GitHub Enterprise GHCR. Nov 4, 2024
@Jaypers
Copy link
Author

Jaypers commented Nov 19, 2024

Hi @davidcollom, do you maybe have an idea for a workaround? Did I miss something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants