Flip URIUtil.toURI behavior to perform URI before Path in the implementation

Author: joakime

jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/URIUtil.java

@@ -16,7 +16,6 @@
 import java.io.File;
 import java.io.IOException;
 import java.net.URI;
-import java.net.URISyntaxException;
 import java.net.URL;
 import java.net.URLClassLoader;
 import java.nio.charset.StandardCharsets;
@@ -1919,28 +1918,39 @@ public static URI toURI(String reference)
 
         try
         {
-            Path path = Path.of(reference).toAbsolutePath();
-            return path.toUri();
+            /* Perform URI test first.
+             * We don't want to perform Path.of(String) first.
+             *
+             * Example: reference parameter is the String "file:///path/to/dir"
+             *
+             * On Unix, the Path.of(reference) will result in a relative directory reference
+             * that includes the "file:" portion in the path after the current working directory.
+             * You'll wind up with something like "file:///home/user/code/jetty/12.1.x/jetty-core/jetty-util/file:///path/to/dir" in this case
+             *
+             * On Windows, the Path.of(reference) will not allow a Path.of("file:///path/to/dir") to work.
+             * This is because there cannot be multi-character drive letters (yes, Windows is limited to only 26 drive letters max)
+             */
+            URI uri = URI.create(reference);
+            if (uri.isAbsolute())
+                return uri;
+            if (LOG.isDebugEnabled())
+                LOG.debug("Input string is detected as a non-absolute URI \"{}\"", reference);
+            throw new IllegalArgumentException("Non-absolute URI reference strings not supported");
         }
-        catch (InvalidPathException e)
+        catch (IllegalArgumentException e)
         {
-            // Not a path reference.
-            LOG.trace("ignored", e);
+            LOG.trace("IGNORED: Invalid as URI Reference: {}", reference, e);
         }
 
         try
         {
-            URI uri = new URI(reference);
-            if (uri.isAbsolute())
-                return uri;
-            if (LOG.isDebugEnabled())
-                LOG.debug("Input string is detected as a non-absolute URI \"{}\"", reference);
-            throw new IllegalArgumentException("Non-absolute URI reference strings not supported");
+            Path path = Path.of(reference).toAbsolutePath();
+            return path.toUri();
         }
-        catch (URISyntaxException x)
+        catch (InvalidPathException e)
         {
-            // Not a URI reference either.
-            LOG.trace("ignored", x);
+            // Not a path reference.
+            LOG.trace("IGNORED: Invalid as Path Reference: {}", reference, e);
         }
 
         // If we reached this here, that means the input string cannot be used as