Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert inefficient changes made in #12289 #12296

Closed
gregw opened this issue Sep 23, 2024 · 0 comments · Fixed by #12297
Closed

Revert inefficient changes made in #12289 #12296

gregw opened this issue Sep 23, 2024 · 0 comments · Fixed by #12297
Labels
Bug For general bugs on Jetty side

Comments

@gregw
Copy link
Contributor

gregw commented Sep 23, 2024

Jetty version(s)
12.0.x

Jetty Environment
all

Description

The PR #12289 made some unrelated changes to SessionHandler, ContextHandler, ServletContextHandler that mean the list of listeners will be copied and reversed on every single request.
@gregw gregw added the Bug For general bugs on Jetty side label Sep 23, 2024
@gregw gregw changed the title Revert unrelated changes made in #12289 Revert inefficient changes made in #12289 Sep 23, 2024
gregw added a commit that referenced this issue Sep 23, 2024
@gregw
Fix #12296 by partial revert of "Fixes #12289 - Improve ConcurrentPoo…
6084705 
…l concurrency. (#12290)"

This reverts/modified parts of commit 115ee1c.
gregw added a commit that referenced this issue Sep 23, 2024
@gregw
Fix #12296 by partial revert of "Fixes #12289 - Improve ConcurrentPoo…
47d5e0c 
…l concurrency. (#12290)"

This reverts/modified parts of commit 115ee1c.
@lorban lorban linked a pull request Sep 23, 2024 that will close this issue
Avoid list copy on reverse iteration #12297
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For general bugs on Jetty side
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid list copy on reverse iteration jetty/jetty.project
1 participant
@gregw