Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling valgrind's profiling tools? #56

Open
cmpute opened this issue May 14, 2022 · 3 comments
Open

Calling valgrind's profiling tools? #56

cmpute opened this issue May 14, 2022 · 3 comments

Comments

@cmpute
Copy link

cmpute commented May 14, 2022

I wonder do you have any plans to support valgrind's callgrind and cachegrind?

I know that there's a cargo-profiler crate doing this, but the output from their tool doesn't contains enough information for me, I might write a better parser for callgrind and cachegrind output, but I'm more interested in contributing the parser to your tool.

Thanks!

@jfrimmel
Copy link
Owner

Hello and thanks for you interest in this project!

A different tool could be supported, yes. There are two main issues:

  1. the user has to be able to select the tools via an additional command line flag/env var. This could be done via add VALGRINDFLAGS env var #58.
  2. I'm not sure about this, but the XML tool output would likely be different, hence another parser is needed.

Both points are not that difficult, but do simply need work. At the moment I don't have much spare time, so I cannot add those changes in the near future. Feel free to propose a PR if you have the time 👍🏻

@jfrimmel
Copy link
Owner

Could you try out the release 2.1.0? This nicht contain the fix for your issue.

@cmpute
Copy link
Author

cmpute commented Jul 31, 2022

Thanks for your work! I tried using --tool=callgrind flag but unfortunately it seems that callgrind doesn't support XML output:

error: invalid valgrind usage: valgrind: Bad option: --xml=yes
valgrind: Callgrind does not support XML output.
valgrind: Use --help for more information or consult the user manual.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants