Skip to content

Commit a7fdc4f

Browse files
committed
6.4.6 release
Former-commit-id: 3c54049
1 parent d15bcd5 commit a7fdc4f

File tree

12 files changed

+37
-23
lines changed

12 files changed

+37
-23
lines changed

ChangeLog

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,12 @@
1-
05-APR_2017: 6.4.5
1+
06-APR-2017: 6.4.6
2+
3+
- Works around page counter loop condition in FF
4+
5+
05-APR-2017: 6.4.5
26

37
- .vsdx import improvements
48

5-
03-APR_2017: 6.4.4
9+
03-APR-2017: 6.4.4
610

711
- Increases black header title in Conf Cloud to push tick and cross out of visible area
812

VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
6.4.5
1+
6.4.6

src/com/mxgraph/io/vsdx/VsdxShape.java

Lines changed: 19 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,6 @@
2727
import org.w3c.dom.Node;
2828
import org.w3c.dom.NodeList;
2929

30-
import com.mxgraph.io.vsdx.geometry.LineTo;
31-
import com.mxgraph.io.vsdx.geometry.MoveTo;
32-
import com.mxgraph.io.vsdx.geometry.Row;
3330
import com.mxgraph.io.vsdx.theme.Color;
3431
import com.mxgraph.model.mxCell;
3532
import com.mxgraph.model.mxGeometry;
@@ -213,6 +210,11 @@ public VsdxShape(mxVsdxPage page, Element shape, boolean vertex, Map<String, mxV
213210
{
214211
masterShape.processGeomList(null);
215212
processGeomList(masterShape.getGeomList());
213+
214+
//recalculate width and height using master data
215+
if (this.width == 0) this.width = getScreenNumericalValue(getCellElement(mxVsdxConstants.WIDTH), 0);
216+
217+
if (this.height == 0) this.height = getScreenNumericalValue(getCellElement(mxVsdxConstants.HEIGHT), 0);
216218
}
217219
else
218220
{
@@ -1003,6 +1005,12 @@ else if (!(linePattern.equals("0") || linePattern.equals("1")))
10031005
*/
10041006
public double getLineWidth()
10051007
{
1008+
//if an edge has a fill geometry, then the line width matches the min of the shape width & height
1009+
if (!isVertex() && geomList != null && !geomList.isNoFill())
1010+
{
1011+
return Math.min(height, width);
1012+
}
1013+
10061014
String lineWeight = getValue(this.getCellElement(mxVsdxConstants.LINE_WEIGHT), "0");
10071015

10081016
double lWeight = 0;
@@ -1445,7 +1453,7 @@ public Map<String, String> getForm()
14451453
this.styleDebug("shape type = " + type);
14461454

14471455
//The master may contain the foreign object data
1448-
if (this.imageData != null || (mxVsdxConstants.FOREIGN.equals(type) && masterShape.imageData != null))
1456+
if (this.imageData != null || (mxVsdxConstants.FOREIGN.equals(type) && masterShape != null && masterShape.imageData != null))
14491457
{
14501458
Map<String, String> imageData = this.imageData != null? this.imageData : masterShape.imageData;
14511459

@@ -2072,8 +2080,8 @@ public mxCell createLabelSubShape(mxGraph graph, mxCell parent)
20722080
double txtHV = getScreenNumericalValue(getShapeNode(mxVsdxConstants.TXT_HEIGHT), getHeight());
20732081
double txtLocPinXV = getScreenNumericalValue(getShapeNode(mxVsdxConstants.TXT_LOC_PIN_X), txtWV / 2.0);
20742082
double txtLocPinYV = getScreenNumericalValue(getShapeNode(mxVsdxConstants.TXT_LOC_PIN_Y), txtHV / 2.0);
2075-
double txtPinXV =getScreenNumericalValue(getShapeNode(mxVsdxConstants.TXT_PIN_X), 0);
2076-
double txtPinYV = getScreenNumericalValue(getShapeNode(mxVsdxConstants.TXT_PIN_Y), txtHV);
2083+
double txtPinXV =getScreenNumericalValue(getShapeNode(mxVsdxConstants.TXT_PIN_X), txtLocPinXV);
2084+
double txtPinYV = getScreenNumericalValue(getShapeNode(mxVsdxConstants.TXT_PIN_Y), txtLocPinYV);
20772085
double txtAngleV = getValueAsDouble(getShapeNode(mxVsdxConstants.TXT_ANGLE), 0);
20782086

20792087
String textLabel = getTextLabel();
@@ -2084,9 +2092,11 @@ public mxCell createLabelSubShape(mxGraph graph, mxCell parent)
20842092
styleMap.put(mxConstants.STYLE_FILLCOLOR, mxConstants.NONE);
20852093
styleMap.put(mxConstants.STYLE_STROKECOLOR, mxConstants.NONE);
20862094
styleMap.put(mxConstants.STYLE_GRADIENTCOLOR, mxConstants.NONE);
2087-
styleMap.put("align", "center");
2088-
styleMap.put("verticalAlign", "middle");
2089-
styleMap.put("whiteSpace", "wrap");
2095+
2096+
//We don't need to override these attributes in order to properly align the text
2097+
if (!styleMap.containsKey("align")) styleMap.put("align", "center");
2098+
if (!styleMap.containsKey("verticalAlign")) styleMap.put("verticalAlign", "middle");
2099+
if (!styleMap.containsKey("whiteSpace")) styleMap.put("whiteSpace", "wrap");
20902100

20912101
// Doesn't make sense to set a shape, it's not rendered and doesn't affect the text perimeter
20922102
styleMap.remove("shape");

war/WEB-INF/appengine-web.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<appengine-web-app xmlns="http://appengine.google.com/ns/1.0">
33
<application>drawdotio</application>
44
<!-- IMPORTANT! DO NOT CHANGE THIS VALUE IN SOURCE CONTROL! -->
5-
<version>6-4-5</version>
5+
<version>6-4-6</version>
66

77
<!-- Configure java.util.logging -->
88
<system-properties>

war/cache.manifest

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
CACHE MANIFEST
22

33
# THIS FILE WAS GENERATED. DO NOT MODIFY!
4-
# 04/05/2017 03:25 PM
4+
# 04/06/2017 12:53 AM
55

66
app.html
77
index.html?offline=1

war/js/app.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

war/js/atlas-viewer.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)